ash/system/web_notification/ash_popup_alignment_delegate_unittest.cc - Issue 1849623002: Remove unused ash::SHELF_ALIGNMENT_TOP

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/system/web_notification/ash_popup_alignment_delegate_unittest.cc

Issue 1849623002: Remove unused ash::SHELF_ALIGNMENT_TOP (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ash/system/web_notification/ash_popup_alignment_delegate.cc ('k') | ash/system/web_notification/web_notification_tray.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ash/system/web_notification/ash_popup_alignment_delegate_unittest.cc

diff --git a/ash/system/web_notification/ash_popup_alignment_delegate_unittest.cc b/ash/system/web_notification/ash_popup_alignment_delegate_unittest.cc

index c432d28481a6694363b6a243fbc4dff3d7334a07..35ced58c97f47e3754d7649eb662f1b8d1224c0d 100644

--- a/ash/system/web_notification/ash_popup_alignment_delegate_unittest.cc

+++ b/ash/system/web_notification/ash_popup_alignment_delegate_unittest.cc

@@ -135,15 +135,6 @@ TEST_F(AshPopupAlignmentDelegateTest, MAYBE_ShelfAlignment) {

EXPECT_EQ(BOTTOM_LEFT, GetPositionInDisplay(toast_point));

EXPECT_FALSE(alignment_delegate()->IsTopDown());

EXPECT_TRUE(alignment_delegate()->IsFromLeft());

- Shell::GetInstance()->SetShelfAlignment(

- SHELF_ALIGNMENT_TOP,

- Shell::GetPrimaryRootWindow());

- toast_point.set_x(alignment_delegate()->GetToastOriginX(toast_size));

- toast_point.set_y(alignment_delegate()->GetBaseLine());

- EXPECT_EQ(TOP_RIGHT, GetPositionInDisplay(toast_point));

- EXPECT_TRUE(alignment_delegate()->IsTopDown());

- EXPECT_FALSE(alignment_delegate()->IsFromLeft());

}

TEST_F(AshPopupAlignmentDelegateTest, LockScreen) {