Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1844)

Unified Diff: ash/shelf/shelf_view_unittest.cc

Issue 1849623002: Remove unused ash::SHELF_ALIGNMENT_TOP (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/shelf/shelf_view.cc ('k') | ash/shelf/shelf_widget.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/shelf/shelf_view_unittest.cc
diff --git a/ash/shelf/shelf_view_unittest.cc b/ash/shelf/shelf_view_unittest.cc
index 68ebf31bedb4c307383c8fc8627418727b0deb83..76655c3baab035322051ff7a0ef2483a3c3f57ed 100644
--- a/ash/shelf/shelf_view_unittest.cc
+++ b/ash/shelf/shelf_view_unittest.cc
@@ -959,7 +959,6 @@ TEST_F(ShelfViewTest, AssertNoButtonsOverlap) {
const ShelfAlignment kAlignments[] = {
SHELF_ALIGNMENT_LEFT,
SHELF_ALIGNMENT_RIGHT,
- SHELF_ALIGNMENT_TOP,
SHELF_ALIGNMENT_BOTTOM
};
@@ -983,15 +982,14 @@ TEST_F(ShelfViewTest, AssertNoButtonsOverlap) {
// Making sure the overflow bubble arrow correctly tracks with shelf position.
TEST_F(ShelfViewTest, OverflowArrowForShelfPosition) {
const ShelfAlignment kAlignments[] = {
- SHELF_ALIGNMENT_BOTTOM, SHELF_ALIGNMENT_LEFT, SHELF_ALIGNMENT_RIGHT,
- SHELF_ALIGNMENT_TOP};
+ SHELF_ALIGNMENT_BOTTOM, SHELF_ALIGNMENT_LEFT, SHELF_ALIGNMENT_RIGHT};
// These must match what is expected for each alignment above.
const views::BubbleBorder::Arrow kArrows[] = {
views::BubbleBorder::BOTTOM_LEFT, views::BubbleBorder::LEFT_TOP,
- views::BubbleBorder::RIGHT_TOP, views::BubbleBorder::TOP_LEFT};
+ views::BubbleBorder::RIGHT_TOP};
- for (int i = 0; i < 4; i++) {
+ for (size_t i = 0; i < arraysize(kAlignments); i++) {
shelf_view_->shelf()->SetAlignment(kAlignments[i]);
// Make sure there are enough icons to trigger the overflow in new
« no previous file with comments | « ash/shelf/shelf_view.cc ('k') | ash/shelf/shelf_widget.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698