Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2529)

Unified Diff: ash/wm/app_list_controller.cc

Issue 1849623002: Remove unused ash::SHELF_ALIGNMENT_TOP (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/wm/app_list_controller.cc
diff --git a/ash/wm/app_list_controller.cc b/ash/wm/app_list_controller.cc
index d6465d262842e580febe4a7d25c8c8c1d305f541..823c32733048335204dc830fcdede1d47742357e 100644
--- a/ash/wm/app_list_controller.cc
+++ b/ash/wm/app_list_controller.cc
@@ -57,7 +57,7 @@ views::BubbleBorder::Arrow GetBubbleArrow(aura::Window* window) {
DCHECK(Shell::HasInstance());
return Shelf::ForWindow(window)->SelectValueForShelfAlignment(
views::BubbleBorder::BOTTOM_CENTER, views::BubbleBorder::LEFT_CENTER,
- views::BubbleBorder::RIGHT_CENTER, views::BubbleBorder::TOP_CENTER);
+ views::BubbleBorder::RIGHT_CENTER);
}
// Offset given |rect| towards shelf.
@@ -76,9 +76,6 @@ gfx::Rect OffsetTowardsShelf(const gfx::Rect& rect, views::Widget* widget) {
case SHELF_ALIGNMENT_RIGHT:
offseted.Offset(kAnimationOffset, 0);
break;
- case SHELF_ALIGNMENT_TOP:
- offseted.Offset(0, -kAnimationOffset);
- break;
}
return offseted;
@@ -93,7 +90,6 @@ gfx::Vector2d GetAnchorPositionOffsetToShelf(
widget->GetNativeView()->GetRootWindow());
gfx::Point anchor(button_bounds.CenterPoint());
switch (shelf_alignment) {
- case SHELF_ALIGNMENT_TOP:
case SHELF_ALIGNMENT_BOTTOM:
if (base::i18n::IsRTL()) {
int screen_width = widget->GetWorkAreaBoundsInScreen().width();
@@ -109,10 +105,9 @@ gfx::Vector2d GetAnchorPositionOffsetToShelf(
case SHELF_ALIGNMENT_RIGHT:
return gfx::Vector2d(
0, std::max(kMinimalAnchorPositionOffset - anchor.y(), 0));
- default:
- NOTREACHED();
- return gfx::Vector2d();
}
+ NOTREACHED();
+ return gfx::Vector2d();
}
// Gets the point at the center of the display that a particular view is on.
« no previous file with comments | « ash/system/web_notification/web_notification_tray.cc ('k') | ash/wm/panels/attached_panel_window_targeter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698