Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 1848013002: media: Add gles2_interface and ui/gl as explicit dependencies. (Closed)

Created:
4 years, 8 months ago by Daniele Castagna
Modified:
4 years, 8 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

media: Add gles2_interface and ui/gl as explicit dependencies. BUG=599578 Committed: https://crrev.com/aca7d36ab07e8e26dcc9044ec8f23883b4b322e2 Cr-Commit-Position: refs/heads/master@{#384381}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M media/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (3 generated)
Daniele Castagna
Is it OK to have media depending on ui/gl? It seems like media was already ...
4 years, 8 months ago (2016-03-31 19:23:42 UTC) #2
DaleCurtis
Does the root media .gn need this dep or can we keep it in media/video ...
4 years, 8 months ago (2016-03-31 20:12:49 UTC) #3
Daniele Castagna
On 2016/03/31 at 20:12:49, dalecurtis wrote: > Does the root media .gn need this dep ...
4 years, 8 months ago (2016-03-31 20:17:14 UTC) #4
DaleCurtis
Oh we don't already have media/video and media/renderer build.gn files. We should, but that's a ...
4 years, 8 months ago (2016-03-31 20:18:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1848013002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1848013002/1
4 years, 8 months ago (2016-03-31 20:20:32 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-31 20:56:47 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-03-31 20:57:46 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/aca7d36ab07e8e26dcc9044ec8f23883b4b322e2
Cr-Commit-Position: refs/heads/master@{#384381}

Powered by Google App Engine
This is Rietveld 408576698