gl: Add ozone native pixmap bind test.

gl: Add ozone native pixmap bind test.

BUG=605807
TEST=gl_unittests --gtest_also_run_disabled_tests on Samus.

Committed: https://crrev.com/767a614421c19b54b8e282610ee1a8f796d29a26
Cr-Commit-Position: refs/heads/master@{#395697}

[Daniele Castagna, 2016-04-20 09:00:04]

dcastagna@chromium.org changed reviewers:
+ reveman@chromium.org

[reveman, 2016-04-21 02:31:31]

https://codereview.chromium.org/1907433002/diff/1/ui/gl/gl_image_ozone_native...
File ui/gl/gl_image_ozone_native_pixmap_unittest.cc (right):

https://codereview.chromium.org/1907433002/diff/1/ui/gl/gl_image_ozone_native...
ui/gl/gl_image_ozone_native_pixmap_unittest.cc:1: // Copyright 2016 The Chromium
Authors. All rights reserved.
nit: I don't think we update the year in chromium code

https://codereview.chromium.org/1907433002/diff/1/ui/gl/gl_image_ozone_native...
ui/gl/gl_image_ozone_native_pixmap_unittest.cc:33: auto client_pixmap_factory =
ui::ClientNativePixmapFactory::Create();
Would it make more sense to have the factory be a member of
GLImageOzoneNativePixmapTestDelegate? Looks a bit weird that we create a
factory, use it to create a pixmap and then destroy the factory before the
pixmap.

[Daniele Castagna, 2016-04-22 07:45:39]

Disabled the test since the trybot is running with X11 backend.

https://codereview.chromium.org/1907433002/diff/1/ui/gl/gl_image_ozone_native...
File ui/gl/gl_image_ozone_native_pixmap_unittest.cc (right):

https://codereview.chromium.org/1907433002/diff/1/ui/gl/gl_image_ozone_native...
ui/gl/gl_image_ozone_native_pixmap_unittest.cc:1: // Copyright 2016 The Chromium
Authors. All rights reserved.
On 2016/04/21 at 02:31:31, reveman wrote:
> nit: I don't think we update the year in chromium code

Done.

https://codereview.chromium.org/1907433002/diff/1/ui/gl/gl_image_ozone_native...
ui/gl/gl_image_ozone_native_pixmap_unittest.cc:33: auto client_pixmap_factory =
ui::ClientNativePixmapFactory::Create();
On 2016/04/21 at 02:31:31, reveman wrote:
> Would it make more sense to have the factory be a member of
GLImageOzoneNativePixmapTestDelegate? Looks a bit weird that we create a
factory, use it to create a pixmap and then destroy the factory before the
pixmap.

Moved.

[Daniele Castagna, 2016-04-22 07:48:52]

Description was changed from

==========
gl: Add ozone native pixmap bind test.

BUG=
==========

to

==========
gl: Add ozone native pixmap bind test.

BUG=605807
==========

[Daniele Castagna, 2016-05-23 23:44:20]

dcastagna@chromium.org changed reviewers:
+ posciak@chromium.org

[Daniele Castagna, 2016-05-23 23:44:21]

This seems to fail with with crrev.com/2007753002 on samus.
Pawel, I'll take a look at this tomorrow and try to make it work.

[Daniele Castagna, 2016-05-23 23:46:38]

ccing Robert to give him more context on crrev.com/2007753002.

[Daniele Castagna, 2016-05-24 20:26:13]

Patchset #3 (id:40001) has been deleted

[Daniele Castagna, 2016-05-24 20:28:09]

Description was changed from

==========
gl: Add ozone native pixmap bind test.

BUG=605807
==========

to

==========
gl: Add ozone native pixmap bind test.


BUG=605807
TEST=gl_unittests --gtest_also_run_disabled_tests on Samus.
==========

[Daniele Castagna, 2016-05-24 20:28:59]

PTAL.
GLImageOzoneNativePixmap/GLImageBindTest/0.BindTexImage now passes on Samus.

[reveman, 2016-05-24 21:01:23]

lgtm

[Daniele Castagna, 2016-05-24 21:03:27]

The CQ bit was checked by dcastagna@chromium.org

[commit-bot: I haz the power, 2016-05-24 21:04:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1907433002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1907433002/60001

[commit-bot: I haz the power, 2016-05-24 21:20:20]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-05-24 21:21:52]

Description was changed from

==========
gl: Add ozone native pixmap bind test.


BUG=605807
TEST=gl_unittests --gtest_also_run_disabled_tests on Samus.
==========

to

==========
gl: Add ozone native pixmap bind test.

BUG=605807
TEST=gl_unittests --gtest_also_run_disabled_tests on Samus.

Committed: https://crrev.com/767a614421c19b54b8e282610ee1a8f796d29a26
Cr-Commit-Position: refs/heads/master@{#395697}
==========

[commit-bot: I haz the power, 2016-05-24 21:21:53]

Patchset 3 (id:??) landed as
https://crrev.com/767a614421c19b54b8e282610ee1a8f796d29a26
Cr-Commit-Position: refs/heads/master@{#395697}