exo: Add support for importing YVU_420 buffers.

exo: Add support for importing YVU_420 buffers.

This CL adds support for importing YVU_420 buffers via the
wayland drm and dmabuf interfaces into Exo.

BUG=618516
Committed: https://crrev.com/2d7fb78b874098b410bffe3c73cf6c3e392ba3dc
Cr-Commit-Position: refs/heads/master@{#399260}

[Daniele Castagna, 2016-06-06 20:55:31]

Description was changed from

==========
exo: Add support for importing YUV_420 buffers.

This CL adds support for importing YUV_420 buffers via the drm_interface
into Chromium.
==========

to

==========
exo: Add support for importing YUV_420 buffers.

This CL adds support for importing YUV_420 buffers via the
wayland drm_interface into Exo.
==========

[Daniele Castagna, 2016-06-06 20:56:08]

dcastagna@chromium.org changed reviewers:
+ reveman@chromium.org

[reveman, 2016-06-06 21:24:08]

https://codereview.chromium.org/2046743002/diff/1/components/exo/wayland/serv...
File components/exo/wayland/server.cc (right):

https://codereview.chromium.org/2046743002/diff/1/components/exo/wayland/serv...
components/exo/wayland/server.cc:557: // TODO(dcastagna): Add support for
YUV_420.
Please add this format here as well. The interface above is the deprecated
version that we'll remove in the near future.

[Daniele Castagna, 2016-06-09 00:52:47]

Description was changed from

==========
exo: Add support for importing YUV_420 buffers.

This CL adds support for importing YUV_420 buffers via the
wayland drm_interface into Exo.
==========

to

==========
exo: Add support for importing YVU_420 buffers.

This CL adds support for importing YVU_420 buffers via the
wayland drm_interface into Exo.

BUG=618516
==========

[Daniele Castagna, 2016-06-09 21:00:35]

Description was changed from

==========
exo: Add support for importing YVU_420 buffers.

This CL adds support for importing YVU_420 buffers via the
wayland drm_interface into Exo.

BUG=618516
==========

to

==========
exo: Add support for importing YVU_420 buffers.

This CL adds support for importing YVU_420 buffers via the
wayland drm and dmabuf interfaces into Exo.


BUG=618516
==========

[Daniele Castagna, 2016-06-09 21:09:17]

PTAL.

https://codereview.chromium.org/2046743002/diff/1/components/exo/wayland/serv...
File components/exo/wayland/server.cc (right):

https://codereview.chromium.org/2046743002/diff/1/components/exo/wayland/serv...
components/exo/wayland/server.cc:557: // TODO(dcastagna): Add support for
YUV_420.
On 2016/06/06 at 21:24:08, reveman wrote:
> Please add this format here as well. The interface above is the deprecated
version that we'll remove in the near future.

Done. Added also the support for multiple planes in LinuxBufferParams.

[reveman, 2016-06-10 01:57:33]

https://codereview.chromium.org/2046743002/diff/40001/components/exo/display_...
File components/exo/display_unittest.cc (right):

https://codereview.chromium.org/2046743002/diff/40001/components/exo/display_...
components/exo/display_unittest.cc:84: // via Ozone. crbug.com/618516
Oh, we should add the other formats like RGB565 too.

https://codereview.chromium.org/2046743002/diff/40001/components/exo/wayland/...
File components/exo/wayland/server.cc (right):

https://codereview.chromium.org/2046743002/diff/40001/components/exo/wayland/...
components/exo/wayland/server.cc:580: struct Plane {
nit: class/struct before ctor please

https://codereview.chromium.org/2046743002/diff/40001/components/exo/wayland/...
components/exo/wayland/server.cc:658: "missing a plane");
should we continue looping after this?

https://codereview.chromium.org/2046743002/diff/40001/components/exo/wayland/...
components/exo/wayland/server.cc:661: fds.push_back(std::move(plane.fd));
what if plane.fd is not valid?

https://codereview.chromium.org/2046743002/diff/40001/components/exo/wayland/...
components/exo/wayland/server.cc:668: plane_idx > 3) {  // We don't support any
format with more than 3 planes.
We know the format here. Could we return an error if the planes don't match what
we expect for the format?

[Daniele Castagna, 2016-06-10 02:08:24]

https://codereview.chromium.org/2046743002/diff/40001/components/exo/display_...
File components/exo/display_unittest.cc (right):

https://codereview.chromium.org/2046743002/diff/40001/components/exo/display_...
components/exo/display_unittest.cc:84: // via Ozone. crbug.com/618516
On 2016/06/10 at 01:57:32, reveman wrote:
> Oh, we should add the other formats like RGB565 too.

Will do in a follow-up CL.

https://codereview.chromium.org/2046743002/diff/40001/components/exo/wayland/...
File components/exo/wayland/server.cc (right):

https://codereview.chromium.org/2046743002/diff/40001/components/exo/wayland/...
components/exo/wayland/server.cc:580: struct Plane {
On 2016/06/10 at 01:57:32, reveman wrote:
> nit: class/struct before ctor please

Done.

https://codereview.chromium.org/2046743002/diff/40001/components/exo/wayland/...
components/exo/wayland/server.cc:658: "missing a plane");
On 2016/06/10 at 01:57:32, reveman wrote:
> should we continue looping after this?

No, return added.

https://codereview.chromium.org/2046743002/diff/40001/components/exo/wayland/...
components/exo/wayland/server.cc:661: fds.push_back(std::move(plane.fd));
On 2016/06/10 at 01:57:32, reveman wrote:
> what if plane.fd is not valid?

We shouldn't add it then. Done.

https://codereview.chromium.org/2046743002/diff/40001/components/exo/wayland/...
components/exo/wayland/server.cc:668: plane_idx > 3) {  // We don't support any
format with more than 3 planes.
On 2016/06/10 at 01:57:32, reveman wrote:
> We know the format here. Could we return an error if the planes don't match
what we expect for the format?

Yes, added the check before looping on the planes.

[reveman, 2016-06-10 03:13:32]

lgtm

[Daniele Castagna, 2016-06-10 19:30:15]

Patchset #6 (id:100001) has been deleted

[Daniele Castagna, 2016-06-10 19:31:49]

The CQ bit was checked by dcastagna@chromium.org

[Daniele Castagna, 2016-06-10 19:31:49]

The patchset sent to the CQ was uploaded after l-g-t-m from reveman@chromium.org
Link to the patchset: https://codereview.chromium.org/2046743002/#ps120001
(title: "Avoid vector aggregate initialization in exo test.")

[commit-bot: I haz the power, 2016-06-10 19:32:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2046743002/120001

[commit-bot: I haz the power, 2016-06-10 20:16:09]

Committed patchset #6 (id:120001)

[commit-bot: I haz the power, 2016-06-10 20:19:13]

Description was changed from

==========
exo: Add support for importing YVU_420 buffers.

This CL adds support for importing YVU_420 buffers via the
wayland drm and dmabuf interfaces into Exo.


BUG=618516
==========

to

==========
exo: Add support for importing YVU_420 buffers.

This CL adds support for importing YVU_420 buffers via the
wayland drm and dmabuf interfaces into Exo.

BUG=618516

Committed: https://crrev.com/2d7fb78b874098b410bffe3c73cf6c3e392ba3dc
Cr-Commit-Position: refs/heads/master@{#399260}
==========

[commit-bot: I haz the power, 2016-06-10 20:19:13]

Patchset 6 (id:??) landed as
https://crrev.com/2d7fb78b874098b410bffe3c73cf6c3e392ba3dc
Cr-Commit-Position: refs/heads/master@{#399260}