Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 2052543004: gl: Test YV12 buffer drm import. (Closed)

Created:
4 years, 6 months ago by Daniele Castagna
Modified:
4 years, 6 months ago
CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@yv12-pixmap-support
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gl: Test YV12 buffer drm import. Adds a test to check that importing YV12 format created via drm works and that it is possible to draw after creating an EGL image backed by them. BUG=618516 TEST=gl_unittests on samus. Committed: https://crrev.com/fa3d958da6046d3ba59724b98befed3f1cca1430 Cr-Commit-Position: refs/heads/master@{#398931}

Patch Set 1 #

Patch Set 2 : Import only one fd. #

Patch Set 3 : Change patch dependency #

Unified diffs Side-by-side diffs Delta from patch set Stats (+179 lines, -1 line) Patch
M ui/gl/BUILD.gn View 4 chunks +14 lines, -0 lines 0 comments Download
A ui/gl/gl_image_ozone_native_pixmap_drm_unittest.cc View 1 1 chunk +139 lines, -0 lines 0 comments Download
M ui/gl/test/gl_image_test_support.cc View 2 chunks +26 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 17 (6 generated)
Daniele Castagna
dnicoara@, this is just the code for the drm import test. I agree with you ...
4 years, 6 months ago (2016-06-08 22:08:59 UTC) #2
dnicoara
On 2016/06/08 22:08:59, Daniele Castagna wrote: > dnicoara@, this is just the code for the ...
4 years, 6 months ago (2016-06-09 00:45:18 UTC) #3
Daniele Castagna
On 2016/06/09 at 00:45:18, dnicoara wrote: > On 2016/06/08 22:08:59, Daniele Castagna wrote: > > ...
4 years, 6 months ago (2016-06-09 00:51:30 UTC) #4
dnicoara
Thank you! lgtm
4 years, 6 months ago (2016-06-09 00:55:22 UTC) #6
reveman
lgtm
4 years, 6 months ago (2016-06-09 01:08:47 UTC) #7
Daniele Castagna
+Chris for owner approval.
4 years, 6 months ago (2016-06-09 01:29:02 UTC) #9
ccameron
OWNER rs lgtm
4 years, 6 months ago (2016-06-09 06:22:43 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2052543004/40001
4 years, 6 months ago (2016-06-09 16:24:06 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-09 17:26:17 UTC) #14
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-09 17:26:25 UTC) #15
commit-bot: I haz the power
4 years, 6 months ago (2016-06-09 17:30:25 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/fa3d958da6046d3ba59724b98befed3f1cca1430
Cr-Commit-Position: refs/heads/master@{#398931}

Powered by Google App Engine
This is Rietveld 408576698