Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 1846373002: Revert of Patch to try dump-on-DCHECK. (Closed)

Created:
4 years, 8 months ago by Wez
Modified:
4 years, 8 months ago
Reviewers:
danakj, hans, Nico, scottmg
CC:
chromium-reviews, laforge, Primiano Tucci (use gerrit), dcheng, scottmg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Patch to try dump-on-DCHECK. (patchset #13 id:240001 of https://codereview.chromium.org/1814423002/ ) Reason for revert: We will run this trial the week of April 4th => reverting until then. Original issue's description: > Patch to try dump-on-DCHECK. > > This patch does two things: > > 1. Adds a flag to switch DCHECK from logging, dumping, and then crashing the process, to only uploading a crash dump, and only on the first failed DCHECK in each process. > > 2. Forces that flag, and DCHECK_ALWAYS_ON, on in Windows official builds. > > All non-debug e.g. CHECK behaviours remain unchanged; the intended effect is for DCHECKs to switch from no-ops to uploading dumps without crashing, in Windows official builds. > > Note that this CL is intended to be landed, a branch cut to release from, and then immediately reverted; it is not intended to be landed in Chromium for any longer period. > > BUG=596231 > > Committed: https://crrev.com/6436ac7ddec4b2b3aba4ee38aabe7dffe238a077 > Cr-Commit-Position: refs/heads/master@{#383894} > > Committed: https://crrev.com/bac26c8a840909a679a5a74557fa6f4f60ae9e07 > Cr-Commit-Position: refs/heads/master@{#384011} > > Committed: https://crrev.com/16502cb143f737bafad5d035b8ed6d76aabce288 > Cr-Commit-Position: refs/heads/master@{#384675} TBR=danakj@chromium.org,scottmg@chromium.org,thakis@chromium.org,hans@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=596231 Committed: https://crrev.com/96292d2ed0cd96cf7a017d1173d4f92683752c71 Cr-Commit-Position: refs/heads/master@{#384709}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -95 lines) Patch
M base/debug/dump_without_crashing.h View 1 chunk +1 line, -2 lines 0 comments Download
M base/debug/dump_without_crashing.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M base/logging.h View 5 chunks +2 lines, -38 lines 0 comments Download
M base/logging.cc View 2 chunks +0 lines, -14 lines 0 comments Download
M base/logging_unittest.cc View 1 chunk +3 lines, -9 lines 0 comments Download
M build/common.gypi View 3 chunks +0 lines, -13 lines 0 comments Download
M build/config/BUILD.gn View 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/wtf/Assertions.h View 1 chunk +4 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Wez
Created Revert of Patch to try dump-on-DCHECK.
4 years, 8 months ago (2016-04-01 22:33:21 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1846373002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1846373002/1
4 years, 8 months ago (2016-04-01 22:34:05 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-01 22:34:59 UTC) #3
commit-bot: I haz the power
4 years, 8 months ago (2016-04-01 22:36:54 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/96292d2ed0cd96cf7a017d1173d4f92683752c71
Cr-Commit-Position: refs/heads/master@{#384709}

Powered by Google App Engine
This is Rietveld 408576698