base/debug/dump_without_crashing.h - Issue 1846373002: Revert of Patch to try dump-on-DCHECK.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/debug/dump_without_crashing.h

Issue 1846373002: Revert of Patch to try dump-on-DCHECK. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/debug/dump_without_crashing.h

diff --git a/base/debug/dump_without_crashing.h b/base/debug/dump_without_crashing.h

index a5c85d5ebeace6991a98b1616d3b0c6c38c3dee1..b8ed17414ac571cddaf435ea978b3fd3e1bb811f 100644

--- a/base/debug/dump_without_crashing.h

+++ b/base/debug/dump_without_crashing.h

@@ -17,8 +17,7 @@

// Before calling this function, call SetDumpWithoutCrashingFunction to pass a

// function pointer, typically chrome!DumpProcessWithoutCrash. See example code

// in chrome_main.cc that does this for chrome.dll.

-// Returns false if called before SetDumpWithoutCrashingFunction.

-BASE_EXPORT bool DumpWithoutCrashing();

+BASE_EXPORT void DumpWithoutCrashing();

// Sets a function that'll be invoked to dump the current process when

// DumpWithoutCrashing() is called.

« no previous file with comments | « no previous file | base/debug/dump_without_crashing.cc » ('j') | no next file with comments »