Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build/config/BUILD.gn

Issue 1846373002: Revert of Patch to try dump-on-DCHECK. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/common.gypi ('k') | third_party/WebKit/Source/wtf/Assertions.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/BUILD.gn
diff --git a/build/config/BUILD.gn b/build/config/BUILD.gn
index 58893181deb5aa0bd526020d64d1546d6cda0e6d..b6d0b71fa0edeaa9b20b0742821c8be9732e6ff8 100644
--- a/build/config/BUILD.gn
+++ b/build/config/BUILD.gn
@@ -92,14 +92,6 @@
if (use_browser_spellchecker) {
defines += [ "USE_BROWSER_SPELLCHECKER=1" ]
}
-
- # In Windows official builds, this will cause DCHECKs to
- # dump-without-crashing. See crbug.com/596231.
- if (is_official_build && is_win) {
- dcheck_always_on = true
- defines += [ "DCHECK_IS_DUMP_WITHOUT_CRASH=1" ]
- }
-
if (dcheck_always_on) {
defines += [ "DCHECK_ALWAYS_ON=1" ]
}
« no previous file with comments | « build/common.gypi ('k') | third_party/WebKit/Source/wtf/Assertions.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698