Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 1845923004: Rename enums in GrContextFactory to remove "GL" (Closed)

Created:
4 years, 8 months ago by bsalomon
Modified:
4 years, 8 months ago
Reviewers:
jvanverth1, egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Rename enums in GrContextFactory to remove "GL" Also, remove kNative as a separate context type and instead make it an alias for kGL or kGLES based on OS. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1845923004 Committed: https://skia.googlesource.com/skia/+/2d9c6f81353597aebf5934547e5cba7a872196fb Committed: https://skia.googlesource.com/skia/+/85b4b53e78dcdeae2a51935ca5e214b0f1a06492

Patch Set 1 #

Patch Set 2 : working #

Total comments: 2

Patch Set 3 : fix targets not named dm #

Patch Set 4 : Fix ANGLE build #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+183 lines, -185 lines) Patch
M bench/nanobench.h View 1 chunk +2 lines, -2 lines 0 comments Download
M bench/nanobench.cpp View 1 2 4 chunks +8 lines, -8 lines 0 comments Download
M dm/DM.cpp View 1 2 3 4 3 chunks +23 lines, -22 lines 0 comments Download
M dm/DMGpuSupport.h View 1 3 chunks +20 lines, -18 lines 0 comments Download
M dm/DMSrcSink.h View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
M dm/DMSrcSink.cpp View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M tests/GrContextAbandonTest.cpp View 1 1 chunk +4 lines, -4 lines 0 comments Download
M tests/GrContextFactoryTest.cpp View 5 chunks +15 lines, -17 lines 0 comments Download
M tests/GrPorterDuffTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/ImageTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/SkpSkGrTest.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/TestConfigParsing.cpp View 1 2 3 4 3 chunks +11 lines, -14 lines 0 comments Download
M tests/VkClearTests.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/VkUploadPixelsTests.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/VkWrapTests.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M tools/flags/SkCommonFlagsConfig.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/flags/SkCommonFlagsConfig.cpp View 1 2 3 4 2 chunks +9 lines, -13 lines 0 comments Download
M tools/gpu/GrContextFactory.h View 1 2 3 2 chunks +36 lines, -37 lines 0 comments Download
M tools/gpu/GrContextFactory.cpp View 1 5 chunks +22 lines, -17 lines 0 comments Download
M tools/kilobench/kilobench.cpp View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M tools/skiaserve/Request.cpp View 1 2 2 chunks +4 lines, -4 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 22 (13 generated)
bsalomon
Prep for adding a Vulkan ContextType. It's all renaming with one exception: I replaced the ...
4 years, 8 months ago (2016-04-01 19:59:14 UTC) #4
egdaniel
lgtm plus question on last left over GL thing https://codereview.chromium.org/1845923004/diff/20001/tools/gpu/GrContextFactory.h File tools/gpu/GrContextFactory.h (right): https://codereview.chromium.org/1845923004/diff/20001/tools/gpu/GrContextFactory.h#newcode118 tools/gpu/GrContextFactory.h:118: ...
4 years, 8 months ago (2016-04-01 20:06:43 UTC) #5
bsalomon
https://codereview.chromium.org/1845923004/diff/20001/tools/gpu/GrContextFactory.h File tools/gpu/GrContextFactory.h (right): https://codereview.chromium.org/1845923004/diff/20001/tools/gpu/GrContextFactory.h#newcode118 tools/gpu/GrContextFactory.h:118: GLTestContext* fGLContext; //! Valid until the factory destroys it ...
4 years, 8 months ago (2016-04-01 20:15:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1845923004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1845923004/40001
4 years, 8 months ago (2016-04-01 20:15:59 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1845923004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1845923004/60001
4 years, 8 months ago (2016-04-01 20:26:49 UTC) #13
commit-bot: I haz the power
Committed patchset #4 (id:60001) as https://skia.googlesource.com/skia/+/2d9c6f81353597aebf5934547e5cba7a872196fb
4 years, 8 months ago (2016-04-01 20:38:12 UTC) #15
bsalomon
A revert of this CL (patchset #4 id:60001) has been created in https://codereview.chromium.org/1856703002/ by bsalomon@google.com. ...
4 years, 8 months ago (2016-04-04 12:37:41 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1845923004/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1845923004/80001
4 years, 8 months ago (2016-04-05 17:49:48 UTC) #20
commit-bot: I haz the power
4 years, 8 months ago (2016-04-05 18:06:31 UTC) #22
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/85b4b53e78dcdeae2a51935ca5e214b0f1a06492

Powered by Google App Engine
This is Rietveld 408576698