Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 1860593002: One signature for creating unit tests that run on premade GrContexts (Closed)

Created:
4 years, 8 months ago by bsalomon
Modified:
4 years, 8 months ago
Reviewers:
jvanverth1, egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@try_no_native
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : fix no gpu build #

Patch Set 3 : rebase #

Patch Set 4 : fix windows? #

Patch Set 5 : another guess to fix windows #

Unified diffs Side-by-side diffs Delta from patch set Stats (+270 lines, -273 lines) Patch
M dm/DM.cpp View 1 2 3 chunks +9 lines, -39 lines 0 comments Download
M tests/BitmapCopyTest.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M tests/BlurTest.cpp View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M tests/ClearTest.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M tests/ClipBoundsTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/CopySurfaceTest.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M tests/EGLImageTest.cpp View 1 chunk +4 lines, -1 line 0 comments Download
M tests/FloatingPointTextureTest.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M tests/GLProgramsTest.cpp View 1 2 chunks +9 lines, -6 lines 0 comments Download
M tests/GpuColorFilterTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/GpuDrawPathTest.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M tests/GpuLayerCacheTest.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M tests/GrContextAbandonTest.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tests/GrContextFactoryTest.cpp View 1 3 chunks +3 lines, -4 lines 0 comments Download
M tests/GrDrawTargetTest.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/GrPorterDuffTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/GrSurfaceTest.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M tests/GrTextureMipMapInvalidationTest.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M tests/ImageFilterCacheTest.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M tests/ImageFilterTest.cpp View 1 2 12 chunks +24 lines, -24 lines 0 comments Download
M tests/ImageIsOpaqueTest.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M tests/ImageNewShaderTest.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/ImageTest.cpp View 1 12 chunks +27 lines, -21 lines 0 comments Download
M tests/PremulAlphaRoundTripTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/PrimitiveProcessorTest.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M tests/ReadPixelsTest.cpp View 8 chunks +9 lines, -9 lines 0 comments Download
M tests/ReadWriteAlphaTest.cpp View 3 chunks +5 lines, -3 lines 0 comments Download
M tests/RecordReplaceDrawTest.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/RectangleTextureTest.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M tests/ResourceCacheTest.cpp View 3 chunks +6 lines, -3 lines 0 comments Download
M tests/SRGBReadWritePixelsTest.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M tests/SpecialImageTest.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M tests/SpecialSurfaceTest.cpp View 1 chunk +5 lines, -4 lines 0 comments Download
M tests/SurfaceTest.cpp View 16 chunks +33 lines, -30 lines 0 comments Download
M tests/TessellatingPathRendererTests.cpp View 1 chunk +4 lines, -3 lines 0 comments Download
M tests/Test.h View 1 2 3 4 3 chunks +33 lines, -32 lines 0 comments Download
M tests/TestTest.cpp View 1 chunk +6 lines, -16 lines 0 comments Download
M tests/TextBlobCacheTest.cpp View 1 chunk +8 lines, -8 lines 0 comments Download
M tests/TextureStorageAllocator.cpp View 3 chunks +6 lines, -4 lines 0 comments Download
M tests/WritePixelsTest.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M tools/gpu/GrContextFactory.h View 1 2 chunks +11 lines, -10 lines 0 comments Download
M tools/gpu/GrContextFactory.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 20 (11 generated)
bsalomon
Currently the macros for writing tests that take premade GrConexts can take either just a ...
4 years, 8 months ago (2016-04-04 19:04:42 UTC) #3
jvanverth1
lgtm We should probably talk about the structure of VulkanTestContext vs GLTestContext. Right now I ...
4 years, 8 months ago (2016-04-04 20:38:00 UTC) #4
jvanverth1
On 2016/04/04 20:38:00, jvanverth1 wrote: > lgtm > > We should probably talk about the ...
4 years, 8 months ago (2016-04-04 20:38:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1860593002/30001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1860593002/30001
4 years, 8 months ago (2016-04-05 18:07:50 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_64-Debug-Trybot/builds/7679)
4 years, 8 months ago (2016-04-05 18:11:21 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1860593002/50001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1860593002/50001
4 years, 8 months ago (2016-04-05 18:57:08 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-Debug-Trybot/builds/7638)
4 years, 8 months ago (2016-04-05 19:00:19 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1860593002/70001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1860593002/70001
4 years, 8 months ago (2016-04-05 19:47:26 UTC) #18
commit-bot: I haz the power
4 years, 8 months ago (2016-04-05 19:59:12 UTC) #20
Message was sent while issue was closed.
Committed patchset #5 (id:70001) as
https://skia.googlesource.com/skia/+/f2f1c17e331fe1e0ce695969970ecebc81e12ceb

Powered by Google App Engine
This is Rietveld 408576698