Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(681)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 184553009: Android native accessibility: Decorate link nodes with URLSpans. (Closed)

Created:
6 years, 9 months ago by Peter Lundblad
Modified:
6 years, 9 months ago
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, jam, yuzo+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, Kristian Monsen
Base URL:
https://chromium.googlesource.com/chromium/src.git@debugcrash
Visibility:
Public.

Description

Android native accessibility: Decorate link nodes with URLSpans. This makes talkback recognize the accessibility node as containing a link. R=dmazzoni@chromium.org BUG=348184 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255854

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fix comments from Dominic and Kristian. #

Patch Set 3 : Fix test expectations. #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -23 lines) Patch
M content/browser/accessibility/browser_accessibility_android.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_android.cc View 1 2 chunks +4 lines, -6 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_manager_android.cc View 1 1 chunk +6 lines, -3 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java View 1 2 chunks +16 lines, -3 lines 0 comments Download
M content/test/data/accessibility/a-expected-android.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/a-name-expected-android.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/a-onclick-expected-android.txt View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M content/test/data/accessibility/a-with-img-expected-android.txt View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M content/test/data/accessibility/canvas-expected-android.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/contenteditable-descendants-expected-android.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/modal-dialog-opened-expected-android.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 31 (0 generated)
Peter Lundblad
6 years, 9 months ago (2014-02-28 23:23:16 UTC) #1
dmazzoni
lgtm We shouldn't land this until TalkBack is updated, right? https://codereview.chromium.org/184553009/diff/1/content/browser/accessibility/browser_accessibility_android.cc File content/browser/accessibility/browser_accessibility_android.cc (right): https://codereview.chromium.org/184553009/diff/1/content/browser/accessibility/browser_accessibility_android.cc#newcode194 ...
6 years, 9 months ago (2014-03-03 22:41:28 UTC) #2
Peter Lundblad
dmazzoni@chromium.org writes: > lgtm > > We shouldn't land this until TalkBack is updated, right? ...
6 years, 9 months ago (2014-03-05 06:39:55 UTC) #3
Peter Lundblad
Fix Kristian's email.
6 years, 9 months ago (2014-03-05 06:46:51 UTC) #4
Kristian Monsen
lgtm, one suggestion but it is fine as is as well. https://codereview.chromium.org/184553009/diff/1/content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java File content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java (right): ...
6 years, 9 months ago (2014-03-05 07:43:55 UTC) #5
Peter Lundblad
The CQ bit was checked by plundblad@chromium.org
6 years, 9 months ago (2014-03-06 01:56:00 UTC) #6
Peter Lundblad
kristianm@chromium.org writes: > lgtm, one suggestion but it is fine as is as well. > ...
6 years, 9 months ago (2014-03-06 01:56:58 UTC) #7
Peter Lundblad
dmazzoni@chromium.org writes: > lgtm > > We shouldn't land this until TalkBack is updated, right? ...
6 years, 9 months ago (2014-03-06 01:58:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/plundblad@chromium.org/184553009/20001
6 years, 9 months ago (2014-03-06 02:00:37 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/plundblad@chromium.org/184553009/20001
6 years, 9 months ago (2014-03-06 02:59:54 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/plundblad@chromium.org/184553009/20001
6 years, 9 months ago (2014-03-06 03:21:25 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-06 04:37:32 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg
6 years, 9 months ago (2014-03-06 04:37:32 UTC) #13
Kristian Monsen
The CQ bit was checked by kristianm@chromium.org
6 years, 9 months ago (2014-03-06 04:38:45 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/plundblad@chromium.org/184553009/20001
6 years, 9 months ago (2014-03-06 04:39:39 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-06 12:26:36 UTC) #16
commit-bot: I haz the power
The commit queue went berserk retrying too often for a seemingly flaky test on builder ...
6 years, 9 months ago (2014-03-06 12:26:37 UTC) #17
Peter Lundblad
The CQ bit was checked by plundblad@chromium.org
6 years, 9 months ago (2014-03-06 17:11:32 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/plundblad@chromium.org/184553009/20001
6 years, 9 months ago (2014-03-06 17:15:00 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/plundblad@chromium.org/184553009/20001
6 years, 9 months ago (2014-03-06 20:50:36 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/plundblad@chromium.org/184553009/20001
6 years, 9 months ago (2014-03-06 21:38:59 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/plundblad@chromium.org/184553009/20001
6 years, 9 months ago (2014-03-06 22:14:31 UTC) #22
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-07 08:59:21 UTC) #23
commit-bot: I haz the power
The commit queue went berserk retrying too often for a seemingly flaky test on builder ...
6 years, 9 months ago (2014-03-07 08:59:22 UTC) #24
Peter Lundblad
The CQ bit was checked by plundblad@chromium.org
6 years, 9 months ago (2014-03-09 05:07:45 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/plundblad@chromium.org/184553009/60001
6 years, 9 months ago (2014-03-09 05:07:50 UTC) #26
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-09 08:31:26 UTC) #27
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=278306
6 years, 9 months ago (2014-03-09 08:31:26 UTC) #28
Kristian Monsen
The CQ bit was checked by kristianm@chromium.org
6 years, 9 months ago (2014-03-09 16:31:55 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/plundblad@chromium.org/184553009/60001
6 years, 9 months ago (2014-03-09 16:32:04 UTC) #30
commit-bot: I haz the power
6 years, 9 months ago (2014-03-09 17:12:42 UTC) #31
Message was sent while issue was closed. 
Change committed as 255854

Powered by Google App Engine
This is Rietveld 408576698