content/browser/accessibility/browser_accessibility_android.cc - Issue 184553009: Android native accessibility: Decorate link nodes with URLSpans.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/browser_accessibility_android.cc

Issue 184553009: Android native accessibility: Decorate link nodes with URLSpans. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@debugcrash

Patch Set: rebase Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/accessibility/browser_accessibility_android.h ('k') | content/browser/accessibility/browser_accessibility_manager_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/accessibility/browser_accessibility_android.cc

diff --git a/content/browser/accessibility/browser_accessibility_android.cc b/content/browser/accessibility/browser_accessibility_android.cc

index b86374a02ec354ff79f3e20180ccf48b64ba865e..5b9731784663dbcd6ad85ea04b1f5f47e719e994 100644

--- a/content/browser/accessibility/browser_accessibility_android.cc

+++ b/content/browser/accessibility/browser_accessibility_android.cc

@@ -164,6 +164,10 @@ bool BrowserAccessibilityAndroid::IsHierarchical() const {

role() == ui::AX_ROLE_TREE);

}

+bool BrowserAccessibilityAndroid::IsLink() const {

+ return role() == ui::AX_ROLE_LINK || role() == ui::AX_ROLE_IMAGE_MAP_LINK;

bool BrowserAccessibilityAndroid::IsMultiLine() const {

return role() == ui::AX_ROLE_TEXT_AREA;

}

@@ -280,12 +284,6 @@ base::string16 BrowserAccessibilityAndroid::GetText() const {

}

switch(role()) {

- case ui::AX_ROLE_IMAGE_MAP_LINK:

- case ui::AX_ROLE_LINK:

- if (!text.empty())

- text += base::ASCIIToUTF16(" ");

- text += base::ASCIIToUTF16("Link");

- break;

case ui::AX_ROLE_HEADING:

// Only append "heading" if this node already has text.

if (!text.empty())