content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java - Issue 184553009: Android native accessibility: Decorate link nodes with URLSpans.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java

Issue 184553009: Android native accessibility: Decorate link nodes with URLSpans. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@debugcrash

Patch Set: rebase Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/accessibility/browser_accessibility_manager_android.cc ('k') | content/test/data/accessibility/a-expected-android.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java b/content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java

index c427bfef8a7e1d126fea65386bcd876f6c2910f7..d92e69fd1ea69ffdfa32709c7ae8c2135631504c 100644

--- a/content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java

+++ b/content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java

@@ -8,6 +8,8 @@ import android.content.Context;

import android.graphics.Rect;

import android.os.Build;

import android.os.Bundle;

+import android.text.SpannableString;

+import android.text.style.URLSpan;

import android.view.MotionEvent;

import android.view.View;

import android.view.ViewParent;

@@ -447,10 +449,21 @@ public class BrowserAccessibilityManager {

}

@CalledByNative

- private void setAccessibilityNodeInfoStringAttributes(AccessibilityNodeInfo node,

- String className, String contentDescription) {

+ private void setAccessibilityNodeInfoClassName(AccessibilityNodeInfo node,

+ String className) {

node.setClassName(className);

- node.setContentDescription(contentDescription);

+ }

+ @CalledByNative

+ private void setAccessibilityNodeInfoContentDescription(

+ AccessibilityNodeInfo node, String contentDescription, boolean annotateAsLink) {

+ if (annotateAsLink) {

+ SpannableString spannable = new SpannableString(contentDescription);

+ spannable.setSpan(new URLSpan(""), 0, spannable.length(), 0);

+ node.setContentDescription(spannable);

+ } else {

+ node.setContentDescription(contentDescription);

+ }

}

@CalledByNative