content/browser/accessibility/browser_accessibility_manager_android.cc - Issue 184553009: Android native accessibility: Decorate link nodes with URLSpans.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/browser_accessibility_manager_android.cc

Issue 184553009: Android native accessibility: Decorate link nodes with URLSpans. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@debugcrash

Patch Set: rebase Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/accessibility/browser_accessibility_android.cc ('k') | content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/accessibility/browser_accessibility_manager_android.cc

diff --git a/content/browser/accessibility/browser_accessibility_manager_android.cc b/content/browser/accessibility/browser_accessibility_manager_android.cc

index 114ba7fcdbf774dbcac9b3e8a6a4a7bd7077c5c3..9516efe936275e6d7d8c2419504ed480060cde54 100644

--- a/content/browser/accessibility/browser_accessibility_manager_android.cc

+++ b/content/browser/accessibility/browser_accessibility_manager_android.cc

@@ -222,10 +222,13 @@ jboolean BrowserAccessibilityManagerAndroid::PopulateAccessibilityNodeInfo(

node->IsScrollable(),

node->IsSelected(),

node->IsVisibleToUser());

- Java_BrowserAccessibilityManager_setAccessibilityNodeInfoStringAttributes(

+ Java_BrowserAccessibilityManager_setAccessibilityNodeInfoClassName(

env, obj, info,

- base::android::ConvertUTF8ToJavaString(env, node->GetClassName()).obj(),

- base::android::ConvertUTF16ToJavaString(env, node->GetText()).obj());

+ base::android::ConvertUTF8ToJavaString(env, node->GetClassName()).obj());

+ Java_BrowserAccessibilityManager_setAccessibilityNodeInfoContentDescription(

+ env, obj, info,

+ base::android::ConvertUTF16ToJavaString(env, node->GetText()).obj(),

+ node->IsLink());

gfx::Rect absolute_rect = node->GetLocalBoundsRect();

gfx::Rect parent_relative_rect = absolute_rect;