Remove usages of Heap::NewSpaceStart and its external reference

Remove usages of Heap::NewSpaceStart and its external reference

Replace the uses with proper page flag lookups.

BUG=chromium:581412
LOG=N
TEST=mjsunit/allocation-site-info

Committed: https://crrev.com/f2a585935fa070d2b4fb78389045d4df5253dd96
Cr-Commit-Position: refs/heads/master@{#35153}

[Michael Lippautz, 2016-03-30 13:04:56]

Patchset #4 (id:60001) has been deleted

[Michael Lippautz, 2016-03-30 13:06:03]

Description was changed from

==========
[heap] Remove usages of Heap::NewSpaceStart and its external reference

Replace the uses with proper page flag lookups.

BUG=chromium:581412
LOG=N
TEST=mjsunit/allocation-site-info
==========

to

==========
Remove usages of Heap::NewSpaceStart and its external reference

Replace the uses with proper page flag lookups.

BUG=chromium:581412
LOG=N
TEST=mjsunit/allocation-site-info
==========

[Michael Lippautz, 2016-03-30 13:10:52]

The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-30 13:11:00]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1845463003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1845463003/80001

[commit-bot: I haz the power, 2016-03-30 13:34:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-30 13:34:42]

Dry run: Try jobs failed on following builders:
  v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel/build...)

[Michael Lippautz, 2016-03-30 14:50:34]

The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-30 14:50:45]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1845463003/80002
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1845463003/80002

[commit-bot: I haz the power, 2016-03-30 15:16:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-30 15:16:44]

Dry run: This issue passed the CQ dry run.

[Michael Lippautz, 2016-03-30 15:22:21]

mlippautz@chromium.org changed reviewers:
+ ulan@chromium.org

[Michael Lippautz, 2016-03-30 15:22:22]

ulan: PTAL; looks performance neutral on the try bots. Any suggestions on
reducing the instructions appreciated.

Kudos to mvstanton for coming up with a test for this!

https://codereview.chromium.org/1845463003/diff/80002/src/mips/macro-assemble...
File src/mips/macro-assembler-mips.cc (left):

https://codereview.chromium.org/1845463003/diff/80002/src/mips/macro-assemble...
src/mips/macro-assembler-mips.cc:6078: if (allocation_memento_present) {
The way this was implemented was slightly better (only 1 instead of 2 branches),
but I found it quite unreadable (cond + presence of label). See
lithium-codegen-mips.cc for the caller...

The new implementation is now the same on all platforms.

[Michael Lippautz, 2016-03-30 17:24:49]

As discussed offline, I reduced the constants used (only page mask now), and
reordered the checks to have an early bailout for arrays in old space.

[Michael Lippautz, 2016-03-30 17:24:56]

The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-30 17:25:05]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1845463003/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1845463003/100001

[commit-bot: I haz the power, 2016-03-30 17:29:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-30 17:29:16]

Dry run: Try jobs failed on following builders:
  v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/1...)

[Michael Lippautz, 2016-03-30 17:38:01]

Patchset #6 (id:100001) has been deleted

[Michael Lippautz, 2016-03-30 17:41:22]

The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-30 17:41:28]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1845463003/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1845463003/120001

[commit-bot: I haz the power, 2016-03-30 18:01:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-30 18:01:21]

Dry run: This issue passed the CQ dry run.

[ulan, 2016-03-30 18:11:35]

lgtm

[Michael Lippautz, 2016-03-30 18:24:30]

+v8-ppc-ports

[Michael Lippautz, 2016-03-30 18:24:39]

The CQ bit was checked by mlippautz@chromium.org

[commit-bot: I haz the power, 2016-03-30 18:24:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1845463003/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1845463003/120001

[commit-bot: I haz the power, 2016-03-30 18:28:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-30 18:28:01]

Try jobs failed on following builders:
  v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/13011)

[Michael Lippautz, 2016-03-30 18:38:07]

mlippautz@chromium.org changed reviewers:
+ verwaest@chromium.org

[Michael Lippautz, 2016-03-30 18:38:08]

+Toon

Need a stamp for crankshaft/, please.

[Toon Verwaest, 2016-03-31 07:51:15]

crankshaft lgtm

[Michael Lippautz, 2016-03-31 07:52:11]

The CQ bit was checked by mlippautz@chromium.org

[commit-bot: I haz the power, 2016-03-31 07:52:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1845463003/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1845463003/120001

[commit-bot: I haz the power, 2016-03-31 07:54:28]

Description was changed from

==========
Remove usages of Heap::NewSpaceStart and its external reference

Replace the uses with proper page flag lookups.

BUG=chromium:581412
LOG=N
TEST=mjsunit/allocation-site-info
==========

to

==========
Remove usages of Heap::NewSpaceStart and its external reference

Replace the uses with proper page flag lookups.

BUG=chromium:581412
LOG=N
TEST=mjsunit/allocation-site-info
==========

[commit-bot: I haz the power, 2016-03-31 07:54:29]

Committed patchset #6 (id:120001)

[commit-bot: I haz the power, 2016-03-31 07:55:42]

Description was changed from

==========
Remove usages of Heap::NewSpaceStart and its external reference

Replace the uses with proper page flag lookups.

BUG=chromium:581412
LOG=N
TEST=mjsunit/allocation-site-info
==========

to

==========
Remove usages of Heap::NewSpaceStart and its external reference

Replace the uses with proper page flag lookups.

BUG=chromium:581412
LOG=N
TEST=mjsunit/allocation-site-info

Committed: https://crrev.com/f2a585935fa070d2b4fb78389045d4df5253dd96
Cr-Commit-Position: refs/heads/master@{#35153}
==========

[commit-bot: I haz the power, 2016-03-31 07:55:43]

Patchset 6 (id:??) landed as
https://crrev.com/f2a585935fa070d2b4fb78389045d4df5253dd96
Cr-Commit-Position: refs/heads/master@{#35153}