Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Unified Diff: src/heap/spaces.cc

Issue 1845463003: Remove usages of Heap::NewSpaceStart and its external reference (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Only use 1 constant, reordered checks a bit to have earlier bail outs for old space Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/heap/spaces.h ('k') | src/ia32/macro-assembler-ia32.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap/spaces.cc
diff --git a/src/heap/spaces.cc b/src/heap/spaces.cc
index cc8a9beb49eb5a47ef28a06fd6bfa188d96b2bc5..3eedc1eeedbfb6567e2a6066e41469bdeded6812 100644
--- a/src/heap/spaces.cc
+++ b/src/heap/spaces.cc
@@ -1335,8 +1335,6 @@ bool NewSpace::SetUp(int reserved_semispace_capacity,
}
DCHECK(!from_space_.is_committed()); // No need to use memory yet.
- start_ = chunk_base_;
-
ResetAllocationInfo();
return true;
@@ -1353,10 +1351,8 @@ void NewSpace::TearDown() {
promoted_histogram_ = NULL;
}
- start_ = NULL;
allocation_info_.Reset(nullptr, nullptr);
-
to_space_.TearDown();
from_space_.TearDown();
« no previous file with comments | « src/heap/spaces.h ('k') | src/ia32/macro-assembler-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698