src/external-reference-table.cc - Issue 1845463003: Remove usages of Heap::NewSpaceStart and its external reference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/external-reference-table.cc

Issue 1845463003: Remove usages of Heap::NewSpaceStart and its external reference (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Only use 1 constant, reordered checks a bit to have earlier bail outs for old space Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/external-reference-table.cc

diff --git a/src/external-reference-table.cc b/src/external-reference-table.cc

index e6d5bf13da16a3cda77e78ac00f49e292e8d917f..29a2474b091fbbb2b00910e3c9a430659fc1eb16 100644

--- a/src/external-reference-table.cc

+++ b/src/external-reference-table.cc

@@ -31,8 +31,6 @@ ExternalReferenceTable::ExternalReferenceTable(Isolate* isolate) {

"StackGuard::address_of_jslimit()");

Add(ExternalReference::address_of_real_stack_limit(isolate).address(),

"StackGuard::address_of_real_jslimit()");

- Add(ExternalReference::new_space_start(isolate).address(),

- "Heap::NewSpaceStart()");

Add(ExternalReference::new_space_allocation_limit_address(isolate).address(),

"Heap::NewSpaceAllocationLimitAddress()");

Add(ExternalReference::new_space_allocation_top_address(isolate).address(),

« no previous file with comments | « src/crankshaft/mips64/lithium-codegen-mips64.cc ('k') | src/heap/heap.h » ('j') | no next file with comments »