src/assembler.h - Issue 1845463003: Remove usages of Heap::NewSpaceStart and its external reference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/assembler.h

Issue 1845463003: Remove usages of Heap::NewSpaceStart and its external reference (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Only use 1 constant, reordered checks a bit to have earlier bail outs for old space Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/assembler.h

diff --git a/src/assembler.h b/src/assembler.h

index 8dc528547cc63c41c277e919c8b30ed6b210ef92..46566ffe6f1f8b6fbf51d0b4b7534e2c138816ab 100644

--- a/src/assembler.h

+++ b/src/assembler.h

@@ -987,9 +987,6 @@ class ExternalReference BASE_EMBEDDED {

static ExternalReference address_of_regexp_stack_memory_size(

Isolate* isolate);

- // Static variable Heap::NewSpaceStart()

- static ExternalReference new_space_start(Isolate* isolate);

// Write barrier.

static ExternalReference store_buffer_top(Isolate* isolate);

« no previous file with comments | « src/arm64/macro-assembler-arm64.cc ('k') | src/assembler.cc » ('j') | no next file with comments »