third_party/WebKit/Source/platform/text/UnicodeUtilities.cpp - Issue 1845363003: String replaceWithLiteral should just use strlen, also rename to replace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/text/UnicodeUtilities.cpp

Issue 1845363003: String replaceWithLiteral should just use strlen, also rename to replace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Another NUL fix. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/platform/text/UnicodeUtilities.cpp

diff --git a/third_party/WebKit/Source/platform/text/UnicodeUtilities.cpp b/third_party/WebKit/Source/platform/text/UnicodeUtilities.cpp

index 9a14846566171c74fc6e5d0736330c8f5fcd7e7a..55d47b10f9a4f7ddfcf512ae763c3e07dec5b781 100644

--- a/third_party/WebKit/Source/platform/text/UnicodeUtilities.cpp

+++ b/third_party/WebKit/Source/platform/text/UnicodeUtilities.cpp

@@ -77,7 +77,7 @@ void foldQuoteMarksAndSoftHyphens(String& s)

s.replace(rightSingleQuotationMarkCharacter, '\'');

// Replace soft hyphen with an ignorable character so that their presence or absence will

// not affect string comparison.

- s.replace(softHyphenCharacter, 0);

+ s.replace(softHyphenCharacter, static_cast<UChar>('\0'));

}

static bool isNonLatin1Separator(UChar32 character)

« no previous file with comments | « third_party/WebKit/Source/platform/text/LocaleWinTest.cpp ('k') | third_party/WebKit/Source/wtf/text/WTFString.h » ('j') | no next file with comments »