Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1844823002: Fix gn_helpers' parsing of bools. (Closed)

Created:
4 years, 8 months ago by Dirk Pranke
Modified:
4 years, 8 months ago
Reviewers:
brettw
CC:
chromium-reviews, hashimoto
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix gn_helpers' parsing of bools. R=brettw@chromium.org BUG=561142 Committed: https://crrev.com/e031ec2442e681ee5f4e1ffba4629fc3fd28a997 Cr-Commit-Position: refs/heads/master@{#384752}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M build/gn_helpers.py View 1 chunk +1 line, -1 line 0 comments Download
M build/gn_helpers_unittest.py View 1 chunk +7 lines, -0 lines 0 comments Download

Dependent Patchsets:

Issue 1851723002 Patch 1
Issue 1847333005 Patch 1
Issue 1869313002 Patch 1

Messages

Total messages: 7 (2 generated)
Dirk Pranke
4 years, 8 months ago (2016-03-30 02:15:53 UTC) #1
brettw
lgtm
4 years, 8 months ago (2016-03-31 17:49:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1844823002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1844823002/1
4 years, 8 months ago (2016-04-01 23:15:04 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-02 00:17:51 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-02 00:19:03 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/e031ec2442e681ee5f4e1ffba4629fc3fd28a997
Cr-Commit-Position: refs/heads/master@{#384752}

Powered by Google App Engine
This is Rietveld 408576698