Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(948)

Issue 1851723002: Let gn_helpers.py handle unicode as str (Closed)

Created:
4 years, 8 months ago by hashimoto
Modified:
4 years, 8 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Let gn_helpers.py handle unicode as str For some reason, cros_chrome_sdk_unittests passes values as a unicode object, instead of a str. BUG=561142 Committed: https://crrev.com/7bf1d0a550d8bb3eea5e3a2a458c27512c3891a5 Cr-Commit-Position: refs/heads/master@{#384839}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M build/gn_helpers.py View 1 chunk +3 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (3 generated)
hashimoto
4 years, 8 months ago (2016-04-01 05:01:12 UTC) #2
Dirk Pranke
lgtm
4 years, 8 months ago (2016-04-01 20:36:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1851723002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1851723002/1
4 years, 8 months ago (2016-04-04 00:34:51 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-04 01:02:00 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-04 01:03:34 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7bf1d0a550d8bb3eea5e3a2a458c27512c3891a5
Cr-Commit-Position: refs/heads/master@{#384839}

Powered by Google App Engine
This is Rietveld 408576698