build/gn_helpers.py - Issue 1844823002: Fix gn_helpers' parsing of bools.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/gn_helpers.py

Issue 1844823002: Fix gn_helpers' parsing of bools. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/gn_helpers.py

diff --git a/build/gn_helpers.py b/build/gn_helpers.py

index dc0820a62bcb12d3e3c131f463bc65893c95f58e..f1037720bbf878ac8cbaa56f0896aaec04ea5a62 100644

--- a/build/gn_helpers.py

+++ b/build/gn_helpers.py

@@ -280,7 +280,7 @@ class GNValueParser(object):

returns true. Otherwise, returns false and the current position is

unchanged."""

end = self.cur + len(constant)

- if end >= len(self.input):

+ if end > len(self.input):

return False # Not enough room.

if self.input[self.cur:end] == constant:

self.cur = end

« no previous file with comments | « no previous file | build/gn_helpers_unittest.py » ('j') | no next file with comments »