Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1869313002: Roll third_party/chromite to 9bb353c06c398f670e8a33db1eba74760ac3a6d6 (Closed)

Created:
4 years, 8 months ago by hashimoto
Modified:
4 years, 8 months ago
Reviewers:
achuithb, spang
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll third_party/chromite to 9bb353c06c398f670e8a33db1eba74760ac3a6d6 https://chromium.googlesource.com/chromiumos/chromite/+log/e19f83ba227bf1ec0077f5d3a816a415f1dd88d0..9bb353c06c398f670e8a33db1eba74760ac3a6d6 BUG=561142 TEST=cros chrome-sdk, gclient runhooks, deploy_chrome still works

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 1 comment Download

Depends on Patchset:

Issue 1844823002 Patch 1

Messages

Total messages: 7 (3 generated)
hashimoto
4 years, 8 months ago (2016-04-08 06:08:11 UTC) #2
spang
lgtm There's a checklicenses issue in your try runs.
4 years, 8 months ago (2016-04-08 13:42:38 UTC) #4
hashimoto
On 2016/04/08 13:42:38, spang wrote: > lgtm > > There's a checklicenses issue in your ...
4 years, 8 months ago (2016-04-11 04:58:27 UTC) #5
achuithb
4 years, 8 months ago (2016-04-12 23:35:01 UTC) #7 
https://codereview.chromium.org/1869313002/diff/1/DEPS
File DEPS (right):

https://codereview.chromium.org/1869313002/diff/1/DEPS#newcode409
DEPS:409: Var('chromium_git') + '/chromiumos/third_party/pyelftools.git' + '@' +
'bdc1d380acd88d4bfaf47265008091483b0d614e',
I think you may also need to roll this, and it looks like it has diverged.

Powered by Google App Engine
This is Rietveld 408576698