Moving pixel-capturing code from web_test_proxy_base.* into pixel_dump.*

Moving pixel-capturing code from web_test_proxy_base.* into pixel_dump.*

This CL:

- Moves pixel-capturing code from web_test_proxy_base.* into newly
  created pixel_dump.cc and pixel_dump.h.  This helps clean-up
  WebTestProxyBase in preparation for extracting
  view/frame/widget-specific code to separate classes.

- Moves |drag_image_| fields from WebTestProxyBase into TestRunner.
  This also helps clean-up WebTestProxyBase in preparation for
  extracting view/frame/widget-specific code to separate classes.

- Moves |dump_selection_rect| and |dump_drag_image| from TestRunner
  into LayoutTestRuntimeFlags.  This makes sure these flags are
  replicated across renderers as needed.  This also means that accessors
  for these flags no longer need to be exposed by TestRunner.

- Simplifies how WebTestDelegate communicates devices scaling factor
  (used when positioning a pop-up for pixel dump).  This helps
  avoid adding a WebTestDelegate dependency to pixel_dump.h/.cc.

BUG=587175, 595089
TBR=jochen@chromium.org

Committed: https://crrev.com/1b546c1600f9daea517c16b29cddffe515936822
Cr-Commit-Position: refs/heads/master@{#384921}

[Łukasz Anforowicz, 2016-03-31 18:58:31]

Description was changed from

==========
Moving pixel-capturing code from web_test_proxy_base.* into pixel_dump.*

This CL:

- Moves pixel-capturing code from web_test_proxy_base.* into newly
  created pixel_dump.cc and pixel_dump.h.  This helps clean-up
  WebTestProxyBase in preparation for extracting
  view/frame/widget-specific code to separate classes.

- Moves |drag_image_| fields from WebTestProxyBase into TestRunner.
  This also helps clean-up WebTestProxyBase in preparation for
  extracting view/frame/widget-specific code to separate classes.

- Moves |dump_selection_rect| and |dump_drag_image| from TestRunner
  into LayoutTestRuntimeFlags.  This makes sure these flags are
  replicated across renderers as needed.  This also means that accessors
  for these flags no longer need to be exposed by TestRunner.

- Simplifies how WebTestDelegate communicates devices scaling factor
  (used when positioning a pop-up for pixel dump).  This helps
  avoid adding a WebTestDelegate dependency to pixel_dump.h/.cc.

BUG=587175, 595089
==========

to

==========
Moving pixel-capturing code from web_test_proxy_base.* into pixel_dump.*

This CL:

- Moves pixel-capturing code from web_test_proxy_base.* into newly
  created pixel_dump.cc and pixel_dump.h.  This helps clean-up
  WebTestProxyBase in preparation for extracting
  view/frame/widget-specific code to separate classes.

- Moves |drag_image_| fields from WebTestProxyBase into TestRunner.
  This also helps clean-up WebTestProxyBase in preparation for
  extracting view/frame/widget-specific code to separate classes.

- Moves |dump_selection_rect| and |dump_drag_image| from TestRunner
  into LayoutTestRuntimeFlags.  This makes sure these flags are
  replicated across renderers as needed.  This also means that accessors
  for these flags no longer need to be exposed by TestRunner.

- Simplifies how WebTestDelegate communicates devices scaling factor
  (used when positioning a pop-up for pixel dump).  This helps
  avoid adding a WebTestDelegate dependency to pixel_dump.h/.cc.

BUG=587175, 595089
TBR=jochen@chromium.org
==========

[Łukasz Anforowicz, 2016-03-31 18:59:00]

lukasza@chromium.org changed reviewers:
+ jochen@chromium.org

[Łukasz Anforowicz, 2016-03-31 18:59:01]

jochen@, I plan to TBR this CL (it is the same as
https://codereview.chromium.org/1835673002).

[jochen (gone - plz use gerrit), 2016-04-01 08:43:35]

lgtm

[Łukasz Anforowicz, 2016-04-04 14:21:30]

The CQ bit was checked by lukasza@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-04 14:21:49]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1844233004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1844233004/20001

[commit-bot: I haz the power, 2016-04-04 15:25:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-04 15:25:08]

Dry run: This issue passed the CQ dry run.

[Łukasz Anforowicz, 2016-04-04 16:13:51]

The CQ bit was checked by lukasza@chromium.org

[commit-bot: I haz the power, 2016-04-04 16:14:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1844233004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1844233004/20001

[commit-bot: I haz the power, 2016-04-04 16:19:27]

Description was changed from

==========
Moving pixel-capturing code from web_test_proxy_base.* into pixel_dump.*

This CL:

- Moves pixel-capturing code from web_test_proxy_base.* into newly
  created pixel_dump.cc and pixel_dump.h.  This helps clean-up
  WebTestProxyBase in preparation for extracting
  view/frame/widget-specific code to separate classes.

- Moves |drag_image_| fields from WebTestProxyBase into TestRunner.
  This also helps clean-up WebTestProxyBase in preparation for
  extracting view/frame/widget-specific code to separate classes.

- Moves |dump_selection_rect| and |dump_drag_image| from TestRunner
  into LayoutTestRuntimeFlags.  This makes sure these flags are
  replicated across renderers as needed.  This also means that accessors
  for these flags no longer need to be exposed by TestRunner.

- Simplifies how WebTestDelegate communicates devices scaling factor
  (used when positioning a pop-up for pixel dump).  This helps
  avoid adding a WebTestDelegate dependency to pixel_dump.h/.cc.

BUG=587175, 595089
TBR=jochen@chromium.org
==========

to

==========
Moving pixel-capturing code from web_test_proxy_base.* into pixel_dump.*

This CL:

- Moves pixel-capturing code from web_test_proxy_base.* into newly
  created pixel_dump.cc and pixel_dump.h.  This helps clean-up
  WebTestProxyBase in preparation for extracting
  view/frame/widget-specific code to separate classes.

- Moves |drag_image_| fields from WebTestProxyBase into TestRunner.
  This also helps clean-up WebTestProxyBase in preparation for
  extracting view/frame/widget-specific code to separate classes.

- Moves |dump_selection_rect| and |dump_drag_image| from TestRunner
  into LayoutTestRuntimeFlags.  This makes sure these flags are
  replicated across renderers as needed.  This also means that accessors
  for these flags no longer need to be exposed by TestRunner.

- Simplifies how WebTestDelegate communicates devices scaling factor
  (used when positioning a pop-up for pixel dump).  This helps
  avoid adding a WebTestDelegate dependency to pixel_dump.h/.cc.

BUG=587175, 595089
TBR=jochen@chromium.org
==========

[commit-bot: I haz the power, 2016-04-04 16:19:29]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-04 16:21:05]

Description was changed from

==========
Moving pixel-capturing code from web_test_proxy_base.* into pixel_dump.*

This CL:

- Moves pixel-capturing code from web_test_proxy_base.* into newly
  created pixel_dump.cc and pixel_dump.h.  This helps clean-up
  WebTestProxyBase in preparation for extracting
  view/frame/widget-specific code to separate classes.

- Moves |drag_image_| fields from WebTestProxyBase into TestRunner.
  This also helps clean-up WebTestProxyBase in preparation for
  extracting view/frame/widget-specific code to separate classes.

- Moves |dump_selection_rect| and |dump_drag_image| from TestRunner
  into LayoutTestRuntimeFlags.  This makes sure these flags are
  replicated across renderers as needed.  This also means that accessors
  for these flags no longer need to be exposed by TestRunner.

- Simplifies how WebTestDelegate communicates devices scaling factor
  (used when positioning a pop-up for pixel dump).  This helps
  avoid adding a WebTestDelegate dependency to pixel_dump.h/.cc.

BUG=587175, 595089
TBR=jochen@chromium.org
==========

to

==========
Moving pixel-capturing code from web_test_proxy_base.* into pixel_dump.*

This CL:

- Moves pixel-capturing code from web_test_proxy_base.* into newly
  created pixel_dump.cc and pixel_dump.h.  This helps clean-up
  WebTestProxyBase in preparation for extracting
  view/frame/widget-specific code to separate classes.

- Moves |drag_image_| fields from WebTestProxyBase into TestRunner.
  This also helps clean-up WebTestProxyBase in preparation for
  extracting view/frame/widget-specific code to separate classes.

- Moves |dump_selection_rect| and |dump_drag_image| from TestRunner
  into LayoutTestRuntimeFlags.  This makes sure these flags are
  replicated across renderers as needed.  This also means that accessors
  for these flags no longer need to be exposed by TestRunner.

- Simplifies how WebTestDelegate communicates devices scaling factor
  (used when positioning a pop-up for pixel dump).  This helps
  avoid adding a WebTestDelegate dependency to pixel_dump.h/.cc.

BUG=587175, 595089
TBR=jochen@chromium.org

Committed: https://crrev.com/1b546c1600f9daea517c16b29cddffe515936822
Cr-Commit-Position: refs/heads/master@{#384921}
==========

[commit-bot: I haz the power, 2016-04-04 16:21:06]

Patchset 2 (id:??) landed as
https://crrev.com/1b546c1600f9daea517c16b29cddffe515936822
Cr-Commit-Position: refs/heads/master@{#384921}