Moving pixel-capturing code from web_test_proxy_base.* into pixel_dump.*

Moving pixel-capturing code from web_test_proxy_base.* into pixel_dump.*

This CL:

- Moves pixel-capturing code from web_test_proxy_base.* into newly
  created pixel_dump.cc and pixel_dump.h.  This helps clean-up
  WebTestProxyBase in preparation for extracting
  view/frame/widget-specific code to separate classes.

- Moves |drag_image_| fields from WebTestProxyBase into TestRunner.
  This also helps clean-up WebTestProxyBase in preparation for
  extracting view/frame/widget-specific code to separate classes.

- Moves |dump_selection_rect| and |dump_drag_image| from TestRunner
  into LayoutTestRuntimeFlags.  This makes sure these flags are
  replicated across renderers as needed.  This also means that accessors
  for these flags no longer need to be exposed by TestRunner.

- Simplifies how WebTestDelegate communicates devices scaling factor
  (used when positioning a pop-up for pixel dump).  This helps
  avoid adding a WebTestDelegate dependency to pixel_dump.h/.cc.

BUG=587175, 595089
Committed: https://crrev.com/bc3216c1723d16c05d88e26e72727a53bbc0c50b
Cr-Commit-Position: refs/heads/master@{#384109}

[Łukasz Anforowicz, 2016-03-26 00:18:15]

lukasza@chromium.org changed reviewers:
+ jochen@chromium.org

[Łukasz Anforowicz, 2016-03-26 00:18:16]

jochen@, could you please take a look?

[jochen (gone - plz use gerrit), 2016-03-30 16:24:33]

lgtm

[Łukasz Anforowicz, 2016-03-30 18:03:57]

The CQ bit was checked by lukasza@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-30 18:04:34]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1835673002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1835673002/40001

[commit-bot: I haz the power, 2016-03-30 18:08:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-30 18:08:03]

Dry run: Try jobs failed on following builders:
  ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_gn...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[Łukasz Anforowicz, 2016-03-30 20:14:53]

The CQ bit was checked by lukasza@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-30 20:15:06]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1835673002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1835673002/60001

[Łukasz Anforowicz, 2016-03-30 22:01:27]

The CQ bit was unchecked by lukasza@chromium.org

[Łukasz Anforowicz, 2016-03-30 22:01:42]

The CQ bit was checked by lukasza@chromium.org

[Łukasz Anforowicz, 2016-03-30 22:01:42]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/1835673002/#ps60001
(title: "Rebasing...")

[commit-bot: I haz the power, 2016-03-30 22:02:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1835673002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1835673002/60001

[commit-bot: I haz the power, 2016-03-30 22:07:55]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-03-30 22:09:03]

Description was changed from

==========
Moving pixel-capturing code from web_test_proxy_base.* into pixel_dump.*

This CL:

- Moves pixel-capturing code from web_test_proxy_base.* into newly
  created pixel_dump.cc and pixel_dump.h.  This helps clean-up
  WebTestProxyBase in preparation for extracting
  view/frame/widget-specific code to separate classes.

- Moves |drag_image_| fields from WebTestProxyBase into TestRunner.
  This also helps clean-up WebTestProxyBase in preparation for
  extracting view/frame/widget-specific code to separate classes.

- Moves |dump_selection_rect| and |dump_drag_image| from TestRunner
  into LayoutTestRuntimeFlags.  This makes sure these flags are
  replicated across renderers as needed.  This also means that accessors
  for these flags no longer need to be exposed by TestRunner.

- Simplifies how WebTestDelegate communicates devices scaling factor
  (used when positioning a pop-up for pixel dump).  This helps
  avoid adding a WebTestDelegate dependency to pixel_dump.h/.cc.

BUG=587175, 595089
==========

to

==========
Moving pixel-capturing code from web_test_proxy_base.* into pixel_dump.*

This CL:

- Moves pixel-capturing code from web_test_proxy_base.* into newly
  created pixel_dump.cc and pixel_dump.h.  This helps clean-up
  WebTestProxyBase in preparation for extracting
  view/frame/widget-specific code to separate classes.

- Moves |drag_image_| fields from WebTestProxyBase into TestRunner.
  This also helps clean-up WebTestProxyBase in preparation for
  extracting view/frame/widget-specific code to separate classes.

- Moves |dump_selection_rect| and |dump_drag_image| from TestRunner
  into LayoutTestRuntimeFlags.  This makes sure these flags are
  replicated across renderers as needed.  This also means that accessors
  for these flags no longer need to be exposed by TestRunner.

- Simplifies how WebTestDelegate communicates devices scaling factor
  (used when positioning a pop-up for pixel dump).  This helps
  avoid adding a WebTestDelegate dependency to pixel_dump.h/.cc.

BUG=587175, 595089

Committed: https://crrev.com/bc3216c1723d16c05d88e26e72727a53bbc0c50b
Cr-Commit-Position: refs/heads/master@{#384109}
==========

[commit-bot: I haz the power, 2016-03-30 22:09:04]

Patchset 4 (id:??) landed as
https://crrev.com/bc3216c1723d16c05d88e26e72727a53bbc0c50b
Cr-Commit-Position: refs/heads/master@{#384109}

[Łukasz Anforowicz, 2016-03-31 14:05:11]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/1842353002/ by lukasza@chromium.org.

The reason for reverting is: Prevents clean reverting of an earlier CL
(https://codereview.chromium.org/1821923003/) tht cause use after free related
to color chooser..