Extract WebViewClient implementation out of WebTestProxyBase.

Extract WebViewClient implementation out of WebTestProxyBase.

Overview
========

This CL extracts WebViewClient-specific parts of WebTestProxyBase into
a new WebViewTestClient class.

This CL is part of a sequence of CLs that make progress toward:

1) Splitting WebTestProxyBase into separate WebFrameClient /
   WebWidgetClient / WebViewClient focused classes

2) Removing WebTestProxyBase from public API of components/test_runner
   (and having WebTestProxy and WebFrameTestProxy consume instead
   abstract WebFrameClient / WebWidgetClient / WebViewClient interfaces).

Details
=======

Most of the change is mechanical move of code from WebTestProxyBase
into the new WebViewTestClient (slightly tweaking method signatures
as needed to make them fit WebViewClient interface - note camelCasing
in particular).

The new WebViewTestClient needs access to
1) WebWidget (for various widget-y things like animations)
2) WebView (this is just a way to help get RenderView pointer in
            BlinkTestRunner::SetFocus method, while avoiding
            component/test_runner -> content dependency).
This CL refactors slightly how WebViewTestClient gets both the WebWidget
and WebView pointers:
1) moving initialization to happen right after creation of these objects
   by RenderViewImpl::Initialize - when
   ContentRenderClient::RenderViewCreated is called
2) to initialize without depending on passing WebTestProxyBase via
   BlinkTestRunner::proxy_ field.
3) to pass WebWidget and WebView separately (rather than depend [inside
   the removed WebTestProxyBase::GetWebView] on the fact that a
   particular upcast from WebWidget to WebView is safe).

WebViewTestClient needs a pointer back to WebTestProxyBase (to be able
to get WebView and WebWidget the client corresponds to).  This means
that a separate WebViewTestClient is needed per WebTestProxyBase (this
is different from WebFrameTestClient which depended only on global
TestInterfaces, TestRunner and mocks).  To accomodate this,
WebTestInterface no longer owns WebViewTestClient and/or
WebFrameTestClient, but instead passes ownership to WebTestProxyBase
and/or WebFrameTestProxyBase.

This CL also moves tracking of some test state (i.e.
animation_scheduled_, speech_recognizer_ mock, etc.) from
WebTestProxyBase into TestRunner (which tracks most of the other test
state).  This means that WebTestProxyBase::Reset method is no longer
needed.

BUG=595089
Committed: https://crrev.com/01da260209729cc19fd30b0d234ec3ecaf3e0766
Cr-Commit-Position: refs/heads/master@{#385173}

[Łukasz Anforowicz, 2016-03-30 21:11:42]

Description was changed from

==========
Extract WebViewClient implementation out of WebTestProxyBase.

Overview
========

This CL extracts WebViewClient-specific parts of WebTestProxyBase into
a new WebViewTestClient class.

This CL is part of a sequence of CLs that make progress toward:

1) Splitting WebTestProxyBase into separate WebFrameClient /
   WebWidgetClient / WebViewClient focused classes

2) Removing WebTestProxyBase from public API of components/test_runner
   (and having WebTestProxy and WebFrameTestProxy consume instead
   abstract WebFrameClient / WebWidgetClient / WebViewClient interfaces).


Details
=======

Most of the change is mechanical move of code from WebTestProxyBase
into the new WebViewTestClient (slightly tweaking method signatures
as needed to make them fit WebViewClient interface - note camelCasing
in particular).

The new WebViewTestClient needs access to
1) WebWidget (for various widget-y things like animations)
2) WebView (this is just a way to help get RenderView pointer in
            BlinkTestRunner::SetFocus method, while avoiding
            component/test_runner -> content dependency).
This CL refactors slightly how WebViewTestClient gets both the WebWidget
and WebView pointers - moving initialization to happen
1) right after creation of these objects by RenderViewImpl::Initialize -
   when ContentRenderClient::RenderViewCreated is called
2) to happen without depending on passing WebTestProxyBase via
   BlinkTestRunner::proxy_ field.
3) to pass WebWidget and WebView separately (rather than depend [inside
   the removed WebTestProxyBase::GetWebView] on the fact that a
   particular upcast from WebWidget to WebView is safe).

WebViewTestClient needs a pointer back to WebTestProxyBase - this means
that a separate WebViewTestClient is needed per WebTestProxyBase (this
is different from WebFrameTestClient which depended only on global
TestInterfaces, TestRunner and mocks).  To accomodate this,
WebTestInterface no longer owns WebViewTestClient and/or
WebFrameTestClient, but instead passes ownership to WebTestProxyBase
and/or WebFrameTestProxyBase.

This CL also moves tracking of some test state (i.e.
animation_scheduled_, speech_recognizer_ mock, etc.) from
WebTestProxyBase into TestRunner (which tracks most of the other test
state).  This means that WebTestProxyBase::Reset method is no longer
needed.


BUG=595089
==========

to

==========
Extract WebViewClient implementation out of WebTestProxyBase.

Overview
========

This CL extracts WebViewClient-specific parts of WebTestProxyBase into
a new WebViewTestClient class.

This CL is part of a sequence of CLs that make progress toward:

1) Splitting WebTestProxyBase into separate WebFrameClient /
   WebWidgetClient / WebViewClient focused classes

2) Removing WebTestProxyBase from public API of components/test_runner
   (and having WebTestProxy and WebFrameTestProxy consume instead
   abstract WebFrameClient / WebWidgetClient / WebViewClient interfaces).


Details
=======

Most of the change is mechanical move of code from WebTestProxyBase
into the new WebViewTestClient (slightly tweaking method signatures
as needed to make them fit WebViewClient interface - note camelCasing
in particular).

The new WebViewTestClient needs access to
1) WebWidget (for various widget-y things like animations)
2) WebView (this is just a way to help get RenderView pointer in
            BlinkTestRunner::SetFocus method, while avoiding
            component/test_runner -> content dependency).
This CL refactors slightly how WebViewTestClient gets both the WebWidget
and WebView pointers:
1) moving initialization to happen right after creation of these objects
   by RenderViewImpl::Initialize - when
   ContentRenderClient::RenderViewCreated is called
2) to initialize without depending on passing WebTestProxyBase via
   BlinkTestRunner::proxy_ field.
3) to pass WebWidget and WebView separately (rather than depend [inside
   the removed WebTestProxyBase::GetWebView] on the fact that a
   particular upcast from WebWidget to WebView is safe).

WebViewTestClient needs a pointer back to WebTestProxyBase (to be able
to get WebView and WebWidget the client corresponds to).  This means
that a separate WebViewTestClient is needed per WebTestProxyBase (this
is different from WebFrameTestClient which depended only on global
TestInterfaces, TestRunner and mocks).  To accomodate this,
WebTestInterface no longer owns WebViewTestClient and/or
WebFrameTestClient, but instead passes ownership to WebTestProxyBase
and/or WebFrameTestProxyBase.

This CL also moves tracking of some test state (i.e.
animation_scheduled_, speech_recognizer_ mock, etc.) from
WebTestProxyBase into TestRunner (which tracks most of the other test
state).  This means that WebTestProxyBase::Reset method is no longer
needed.


BUG=595089
==========

[Łukasz Anforowicz, 2016-03-30 22:48:14]

lukasza@chromium.org changed reviewers:
+ jochen@chromium.org

[Łukasz Anforowicz, 2016-03-30 22:48:15]

jochen@, could you please take a look?

[jochen (gone - plz use gerrit), 2016-03-31 15:14:25]

lgtm

[Łukasz Anforowicz, 2016-03-31 20:59:27]

Just a quick explanation of what changed in the latest patchset (uploaded after
an l-g-t-m) - with the old patch, I would intermittently hit the DCHECK
verifying that number_of_scheduled_animations_ >= 0.  In retrospect this is
expected - sometimes the TestRunner::Reset might happen right between scheduling
and starting an animation in WebViewTestClient.  Therefore in the last patchset
I am not counting pending animations, but rather track set of WebViews with a
scheduled animation - this is more robust, while still allowing resetting test
state in TestRunner::Reset.

[jochen (gone - plz use gerrit), 2016-04-01 08:43:22]

still lgtm

[Łukasz Anforowicz, 2016-04-01 16:14:32]

The CQ bit was checked by lukasza@chromium.org

[Łukasz Anforowicz, 2016-04-01 16:14:41]

The CQ bit was unchecked by lukasza@chromium.org

[commit-bot: I haz the power, 2016-04-01 16:14:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-01 16:14:58]

This CL has an open dependency (Issue 1844233004 Patch 20001). Please resolve
the dependency and try again.

[Łukasz Anforowicz, 2016-04-05 04:24:22]

The CQ bit was checked by lukasza@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-05 04:24:47]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1840823002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1840823002/140001

[commit-bot: I haz the power, 2016-04-05 04:35:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-05 04:35:12]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Łukasz Anforowicz, 2016-04-05 14:05:16]

The CQ bit was checked by lukasza@chromium.org

[Łukasz Anforowicz, 2016-04-05 14:05:17]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/1840823002/#ps160001
(title: "Expanding a comment + an IWYU fix.")

[commit-bot: I haz the power, 2016-04-05 14:05:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1840823002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1840823002/160001

[commit-bot: I haz the power, 2016-04-05 14:51:37]

Committed patchset #9 (id:160001)

[commit-bot: I haz the power, 2016-04-05 14:52:35]

Description was changed from

==========
Extract WebViewClient implementation out of WebTestProxyBase.

Overview
========

This CL extracts WebViewClient-specific parts of WebTestProxyBase into
a new WebViewTestClient class.

This CL is part of a sequence of CLs that make progress toward:

1) Splitting WebTestProxyBase into separate WebFrameClient /
   WebWidgetClient / WebViewClient focused classes

2) Removing WebTestProxyBase from public API of components/test_runner
   (and having WebTestProxy and WebFrameTestProxy consume instead
   abstract WebFrameClient / WebWidgetClient / WebViewClient interfaces).


Details
=======

Most of the change is mechanical move of code from WebTestProxyBase
into the new WebViewTestClient (slightly tweaking method signatures
as needed to make them fit WebViewClient interface - note camelCasing
in particular).

The new WebViewTestClient needs access to
1) WebWidget (for various widget-y things like animations)
2) WebView (this is just a way to help get RenderView pointer in
            BlinkTestRunner::SetFocus method, while avoiding
            component/test_runner -> content dependency).
This CL refactors slightly how WebViewTestClient gets both the WebWidget
and WebView pointers:
1) moving initialization to happen right after creation of these objects
   by RenderViewImpl::Initialize - when
   ContentRenderClient::RenderViewCreated is called
2) to initialize without depending on passing WebTestProxyBase via
   BlinkTestRunner::proxy_ field.
3) to pass WebWidget and WebView separately (rather than depend [inside
   the removed WebTestProxyBase::GetWebView] on the fact that a
   particular upcast from WebWidget to WebView is safe).

WebViewTestClient needs a pointer back to WebTestProxyBase (to be able
to get WebView and WebWidget the client corresponds to).  This means
that a separate WebViewTestClient is needed per WebTestProxyBase (this
is different from WebFrameTestClient which depended only on global
TestInterfaces, TestRunner and mocks).  To accomodate this,
WebTestInterface no longer owns WebViewTestClient and/or
WebFrameTestClient, but instead passes ownership to WebTestProxyBase
and/or WebFrameTestProxyBase.

This CL also moves tracking of some test state (i.e.
animation_scheduled_, speech_recognizer_ mock, etc.) from
WebTestProxyBase into TestRunner (which tracks most of the other test
state).  This means that WebTestProxyBase::Reset method is no longer
needed.


BUG=595089
==========

to

==========
Extract WebViewClient implementation out of WebTestProxyBase.

Overview
========

This CL extracts WebViewClient-specific parts of WebTestProxyBase into
a new WebViewTestClient class.

This CL is part of a sequence of CLs that make progress toward:

1) Splitting WebTestProxyBase into separate WebFrameClient /
   WebWidgetClient / WebViewClient focused classes

2) Removing WebTestProxyBase from public API of components/test_runner
   (and having WebTestProxy and WebFrameTestProxy consume instead
   abstract WebFrameClient / WebWidgetClient / WebViewClient interfaces).

Details
=======

Most of the change is mechanical move of code from WebTestProxyBase
into the new WebViewTestClient (slightly tweaking method signatures
as needed to make them fit WebViewClient interface - note camelCasing
in particular).

The new WebViewTestClient needs access to
1) WebWidget (for various widget-y things like animations)
2) WebView (this is just a way to help get RenderView pointer in
            BlinkTestRunner::SetFocus method, while avoiding
            component/test_runner -> content dependency).
This CL refactors slightly how WebViewTestClient gets both the WebWidget
and WebView pointers:
1) moving initialization to happen right after creation of these objects
   by RenderViewImpl::Initialize - when
   ContentRenderClient::RenderViewCreated is called
2) to initialize without depending on passing WebTestProxyBase via
   BlinkTestRunner::proxy_ field.
3) to pass WebWidget and WebView separately (rather than depend [inside
   the removed WebTestProxyBase::GetWebView] on the fact that a
   particular upcast from WebWidget to WebView is safe).

WebViewTestClient needs a pointer back to WebTestProxyBase (to be able
to get WebView and WebWidget the client corresponds to).  This means
that a separate WebViewTestClient is needed per WebTestProxyBase (this
is different from WebFrameTestClient which depended only on global
TestInterfaces, TestRunner and mocks).  To accomodate this,
WebTestInterface no longer owns WebViewTestClient and/or
WebFrameTestClient, but instead passes ownership to WebTestProxyBase
and/or WebFrameTestProxyBase.

This CL also moves tracking of some test state (i.e.
animation_scheduled_, speech_recognizer_ mock, etc.) from
WebTestProxyBase into TestRunner (which tracks most of the other test
state).  This means that WebTestProxyBase::Reset method is no longer
needed.

BUG=595089

Committed: https://crrev.com/01da260209729cc19fd30b0d234ec3ecaf3e0766
Cr-Commit-Position: refs/heads/master@{#385173}
==========

[commit-bot: I haz the power, 2016-04-05 14:52:36]

Patchset 9 (id:??) landed as
https://crrev.com/01da260209729cc19fd30b0d234ec3ecaf3e0766
Cr-Commit-Position: refs/heads/master@{#385173}