Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Issue 1847033004: Replicate to all renderers the accepted languages set by a layout test. (Closed)

Created:
4 years, 8 months ago by Łukasz Anforowicz
Modified:
4 years, 8 months ago
CC:
chromium-reviews, jochen+watch_chromium.org, mlamouri+watch-test-runner_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@splitting-web-frame-test-client
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replicate to all renderers the accepted languages set by a layout test. Moving |accept_languages_| from WebTestProxyBase into LayoutTestRuntimeFlags helps to 1) replicate the value requested by a test into all renderers 2) prepare WebTestProxyBase to help with extraction of WebViewTestClient class. BUG=587175, 595089 TBR=jochen@chromium.org Committed: https://crrev.com/a0b624a27f13cab7b1e0dcfcafdc71570dc04a0b Cr-Commit-Position: refs/heads/master@{#384908}

Patch Set 1 : Original patch from the reverted https://crrev.com/1829253002 #

Patch Set 2 : Rebasing... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -15 lines) Patch
M components/test_runner/layout_test_runtime_flags.h View 2 chunks +15 lines, -0 lines 0 comments Download
M components/test_runner/layout_test_runtime_flags.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M components/test_runner/test_runner.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/test_runner/test_runner.cc View 1 1 chunk +10 lines, -1 line 0 comments Download
M components/test_runner/tracked_dictionary.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/test_runner/tracked_dictionary.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M components/test_runner/web_test_proxy.h View 2 chunks +0 lines, -4 lines 0 comments Download
M components/test_runner/web_test_proxy.cc View 3 chunks +2 lines, -10 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 10 (5 generated)
Łukasz Anforowicz
jochen@, I'll just TBR this one (this is the same CL as https://codereview.chromium.org/1829253002/).
4 years, 8 months ago (2016-03-31 18:57:34 UTC) #3
jochen (gone - plz use gerrit)
lgtm
4 years, 8 months ago (2016-04-01 08:43:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1847033004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1847033004/20001
4 years, 8 months ago (2016-04-04 14:21:07 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-04 15:00:58 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-04 15:02:27 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a0b624a27f13cab7b1e0dcfcafdc71570dc04a0b
Cr-Commit-Position: refs/heads/master@{#384908}

Powered by Google App Engine
This is Rietveld 408576698