Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1844033004: Revert of Change the battery-status layout tests to use JS mocks. (Closed)

Created:
4 years, 8 months ago by Łukasz Anforowicz
Modified:
4 years, 8 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, mlamouri+watch-test-runner_chromium.org, kinuko+watch, Aaron Boodman, Peter Beverloo, viettrungluu+watch_chromium.org, mlamouri+watch-blink_chromium.org, abarth-chromium, blink-reviews, darin-cc_chromium.org, yzshen+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, mkwst+moarreviews-shell_chromium.org, ben+mojo_chromium.org, darin (slow to review), jochen+watch_chromium.org, qsr+mojo_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Change the battery-status layout tests to use JS mocks. (patchset #4 id:80001 of https://codereview.chromium.org/1836203002/ ) Reason for revert: This CL caused 100 layout tests to crash when run with --site-per-process - see https://crbug.com/599297 Original issue's description: > Change the battery-status layout tests to use JS mocks. > > BUG=597465, 593607 > > Committed: https://crrev.com/33515e2d141a9e16e2430136a80369f3376292b4 > Cr-Commit-Position: refs/heads/master@{#384082} TBR=yukishiino@chromium.org,timvolodine@chromium.org,jam@chromium.org,sammc@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=597465, 593607 Committed: https://crrev.com/88f961ed0a8796a52bf9783b18ae116c8e324876 Cr-Commit-Position: refs/heads/master@{#384147}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+431 lines, -295 lines) Patch
M content/renderer/renderer_blink_platform_impl.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M content/shell/renderer/layout_test/blink_test_runner.cc View 2 chunks +0 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/battery-status/api-defined.html View 3 chunks +25 lines, -11 lines 0 comments Download
M third_party/WebKit/LayoutTests/battery-status/api-defined-expected.txt View 1 chunk +4 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/battery-status/multiple-promises.html View 2 chunks +47 lines, -25 lines 0 comments Download
M third_party/WebKit/LayoutTests/battery-status/multiple-promises-after-resolve.html View 2 chunks +31 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/battery-status/multiple-promises-after-resolve-expected.txt View 1 chunk +10 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/battery-status/multiple-promises-expected.txt View 1 chunk +10 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/battery-status/multiple-windows.html View 2 chunks +31 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/battery-status/multiple-windows-expected.txt View 1 chunk +10 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/battery-status/multiple-windows-page-visibility.html View 5 chunks +32 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/battery-status/multiple-windows-page-visibility-expected.txt View 1 chunk +15 lines, -15 lines 0 comments Download
M third_party/WebKit/LayoutTests/battery-status/no-gc-with-eventlisteners.html View 1 chunk +28 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/battery-status/no-gc-with-eventlisteners-expected.txt View 1 chunk +4 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/battery-status/page-visibility.html View 3 chunks +31 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/battery-status/page-visibility-expected.txt View 1 chunk +10 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/battery-status/promise-with-eventlisteners.html View 6 chunks +34 lines, -11 lines 0 comments Download
M third_party/WebKit/LayoutTests/battery-status/promise-with-eventlisteners-expected.txt View 1 chunk +25 lines, -25 lines 0 comments Download
D third_party/WebKit/LayoutTests/battery-status/resources/mock-battery-monitor.js View 1 chunk +0 lines, -86 lines 0 comments Download
M third_party/WebKit/LayoutTests/battery-status/restricted-level-precision.html View 3 chunks +13 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/resources/mojo-helpers.js View 1 chunk +4 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/battery/BatteryDispatcher.h View 1 chunk +5 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/battery/testing/InternalsBattery.h View 1 chunk +25 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/battery/testing/InternalsBattery.cpp View 1 chunk +17 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/battery/testing/InternalsBattery.idl View 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/modules.gypi View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Łukasz Anforowicz
Created Revert of Change the battery-status layout tests to use JS mocks.
4 years, 8 months ago (2016-03-30 23:54:11 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1844033004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1844033004/1
4 years, 8 months ago (2016-03-30 23:54:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1844033004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1844033004/1
4 years, 8 months ago (2016-03-31 00:02:25 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-31 00:03:34 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/88f961ed0a8796a52bf9783b18ae116c8e324876 Cr-Commit-Position: refs/heads/master@{#384147}
4 years, 8 months ago (2016-03-31 00:04:35 UTC) #7
Yuki
4 years, 8 months ago (2016-03-31 05:44:11 UTC) #8
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698