Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 1836203002: Change the battery-status layout tests to use JS mocks. (Closed)

Created:
4 years, 8 months ago by Sam McNally
Modified:
4 years, 8 months ago
Reviewers:
jam, timvolodine, dcheng, Yuki
CC:
dcheng, Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, blink-reviews, chrome-apps-syd-reviews_chromium.org, chromium-reviews, darin (slow to review), darin-cc_chromium.org, jochen+watch_chromium.org, kinuko+watch, mkwst+moarreviews-renderer_chromium.org, mkwst+moarreviews-shell_chromium.org, mlamouri+watch-test-runner_chromium.org, mlamouri+watch-content_chromium.org, mlamouri+watch-blink_chromium.org, Peter Beverloo, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change the battery-status layout tests to use JS mocks. BUG=597465, 593607 Committed: https://crrev.com/33515e2d141a9e16e2430136a80369f3376292b4 Cr-Commit-Position: refs/heads/master@{#384082} Committed: https://crrev.com/77d2ac27f7ea8f6e54de319baee30754a26e5ac1 Cr-Commit-Position: refs/heads/master@{#384207}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 22

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : rebase #

Patch Set 7 : cleanup in JS unload event #

Total comments: 2

Patch Set 8 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+284 lines, -431 lines) Patch
M content/renderer/renderer_blink_platform_impl.cc View 1 2 3 4 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/battery-status/api-defined.html View 1 2 3 3 chunks +11 lines, -25 lines 0 comments Download
M third_party/WebKit/LayoutTests/battery-status/api-defined-expected.txt View 1 2 3 1 chunk +6 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/battery-status/multiple-promises.html View 1 2 3 2 chunks +27 lines, -49 lines 0 comments Download
M third_party/WebKit/LayoutTests/battery-status/multiple-promises-after-resolve.html View 1 2 3 2 chunks +9 lines, -31 lines 0 comments Download
M third_party/WebKit/LayoutTests/battery-status/multiple-promises-after-resolve-expected.txt View 1 2 3 1 chunk +10 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/battery-status/multiple-promises-expected.txt View 1 2 3 1 chunk +10 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/battery-status/multiple-windows.html View 1 2 3 2 chunks +8 lines, -31 lines 0 comments Download
M third_party/WebKit/LayoutTests/battery-status/multiple-windows-expected.txt View 1 2 3 1 chunk +10 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/battery-status/multiple-windows-page-visibility.html View 1 2 3 5 chunks +9 lines, -32 lines 0 comments Download
M third_party/WebKit/LayoutTests/battery-status/multiple-windows-page-visibility-expected.txt View 1 2 3 1 chunk +15 lines, -15 lines 0 comments Download
M third_party/WebKit/LayoutTests/battery-status/no-gc-with-eventlisteners.html View 1 2 3 1 chunk +12 lines, -28 lines 0 comments Download
M third_party/WebKit/LayoutTests/battery-status/no-gc-with-eventlisteners-expected.txt View 1 2 3 1 chunk +6 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/battery-status/page-visibility.html View 1 2 3 3 chunks +8 lines, -31 lines 0 comments Download
M third_party/WebKit/LayoutTests/battery-status/page-visibility-expected.txt View 1 2 3 1 chunk +10 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/battery-status/promise-with-eventlisteners.html View 1 2 3 6 chunks +11 lines, -34 lines 0 comments Download
M third_party/WebKit/LayoutTests/battery-status/promise-with-eventlisteners-expected.txt View 1 2 3 1 chunk +25 lines, -25 lines 0 comments Download
A third_party/WebKit/LayoutTests/battery-status/resources/mock-battery-monitor.js View 1 2 3 1 chunk +86 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/battery-status/restricted-level-precision.html View 1 2 3 3 chunks +6 lines, -13 lines 0 comments Download
M third_party/WebKit/LayoutTests/resources/mojo-helpers.js View 1 2 3 4 5 6 7 1 chunk +5 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/battery/BatteryDispatcher.h View 1 2 3 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/Source/modules/battery/testing/InternalsBattery.h View 1 chunk +0 lines, -25 lines 0 comments Download
D third_party/WebKit/Source/modules/battery/testing/InternalsBattery.cpp View 1 2 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/WebKit/Source/modules/battery/testing/InternalsBattery.idl View 1 chunk +0 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/modules/modules.gypi View 1 2 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 38 (19 generated)
Sam McNally
4 years, 8 months ago (2016-03-29 23:11:28 UTC) #4
Yuki
Thanks for working on this and showing an example of Mojo mock services. I only ...
4 years, 8 months ago (2016-03-30 02:39:46 UTC) #5
Sam McNally
https://codereview.chromium.org/1836203002/diff/40001/third_party/WebKit/LayoutTests/battery-status/api-defined.html File third_party/WebKit/LayoutTests/battery-status/api-defined.html (right): https://codereview.chromium.org/1836203002/diff/40001/third_party/WebKit/LayoutTests/battery-status/api-defined.html#newcode12 third_party/WebKit/LayoutTests/battery-status/api-defined.html:12: if (!window.internals) On 2016/03/30 02:39:45, Yuki wrote: > Because ...
4 years, 8 months ago (2016-03-30 03:15:33 UTC) #7
Yuki
LGTM. Thanks a lot.
4 years, 8 months ago (2016-03-30 03:23:00 UTC) #8
Sam McNally
+timvolodine for third_party/WebKit/Source/modules/battery +jam for content
4 years, 8 months ago (2016-03-30 03:46:39 UTC) #10
jam
On 2016/03/30 03:46:39, Sam McNally wrote: > +timvolodine for third_party/WebKit/Source/modules/battery > > +jam for content ...
4 years, 8 months ago (2016-03-30 15:55:12 UTC) #11
timvolodine
On 2016/03/30 15:55:12, jam wrote: > On 2016/03/30 03:46:39, Sam McNally wrote: > > +timvolodine ...
4 years, 8 months ago (2016-03-30 17:16:24 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1836203002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1836203002/80001
4 years, 8 months ago (2016-03-30 19:16:01 UTC) #14
commit-bot: I haz the power
Committed patchset #4 (id:80001)
4 years, 8 months ago (2016-03-30 20:42:04 UTC) #16
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/33515e2d141a9e16e2430136a80369f3376292b4 Cr-Commit-Position: refs/heads/master@{#384082}
4 years, 8 months ago (2016-03-30 20:43:10 UTC) #18
Łukasz Anforowicz
On 2016/03/30 20:43:10, commit-bot: I haz the power wrote: > Patchset 4 (id:??) landed as ...
4 years, 8 months ago (2016-03-30 23:52:45 UTC) #19
Łukasz Anforowicz
A revert of this CL (patchset #4 id:80001) has been created in https://codereview.chromium.org/1844033004/ by lukasza@chromium.org. ...
4 years, 8 months ago (2016-03-30 23:54:10 UTC) #20
dcheng
https://codereview.chromium.org/1836203002/diff/160001/third_party/WebKit/LayoutTests/resources/mojo-helpers.js File third_party/WebKit/LayoutTests/resources/mojo-helpers.js (right): https://codereview.chromium.org/1836203002/diff/160001/third_party/WebKit/LayoutTests/resources/mojo-helpers.js#newcode38 third_party/WebKit/LayoutTests/resources/mojo-helpers.js:38: frameServiceRegistry.clearServiceOverridesForTesting(); If a test forgot to call this, does ...
4 years, 8 months ago (2016-03-31 01:31:40 UTC) #24
Sam McNally
https://codereview.chromium.org/1836203002/diff/160001/third_party/WebKit/LayoutTests/resources/mojo-helpers.js File third_party/WebKit/LayoutTests/resources/mojo-helpers.js (right): https://codereview.chromium.org/1836203002/diff/160001/third_party/WebKit/LayoutTests/resources/mojo-helpers.js#newcode38 third_party/WebKit/LayoutTests/resources/mojo-helpers.js:38: frameServiceRegistry.clearServiceOverridesForTesting(); On 2016/03/31 01:31:40, dcheng wrote: > If a ...
4 years, 8 months ago (2016-03-31 01:58:24 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1836203002/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1836203002/180001
4 years, 8 months ago (2016-03-31 03:12:14 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1836203002/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1836203002/180001
4 years, 8 months ago (2016-03-31 05:34:04 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1836203002/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1836203002/180001
4 years, 8 months ago (2016-03-31 07:06:34 UTC) #34
commit-bot: I haz the power
Committed patchset #8 (id:180001)
4 years, 8 months ago (2016-03-31 07:12:11 UTC) #36
commit-bot: I haz the power
4 years, 8 months ago (2016-03-31 07:14:09 UTC) #38
Message was sent while issue was closed.
Patchset 8 (id:??) landed as
https://crrev.com/77d2ac27f7ea8f6e54de319baee30754a26e5ac1
Cr-Commit-Position: refs/heads/master@{#384207}

Powered by Google App Engine
This is Rietveld 408576698