Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1056)

Unified Diff: content/renderer/renderer_blink_platform_impl.cc

Issue 1844033004: Revert of Change the battery-status layout tests to use JS mocks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/shell/renderer/layout_test/blink_test_runner.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/renderer_blink_platform_impl.cc
diff --git a/content/renderer/renderer_blink_platform_impl.cc b/content/renderer/renderer_blink_platform_impl.cc
index 921fbf46535a5af75843778055025876cd334d60..5e76b78b0c8f838aaddfac05f0bfc530cc666343 100644
--- a/content/renderer/renderer_blink_platform_impl.cc
+++ b/content/renderer/renderer_blink_platform_impl.cc
@@ -1166,6 +1166,14 @@
void RendererBlinkPlatformImpl::connectToRemoteService(
const char* name,
mojo::ScopedMessagePipeHandle handle) {
+ // In the layout test mode, mock services should be used instead.
+ // TODO(yukishiino): We'd like to inject mock services implemented in
+ // JavaScript. Remove the following hack once we support JS-bindings
+ // of Mojo and service mocking in JS.
+ if (RenderThreadImpl::current() &&
+ RenderThreadImpl::current()->layout_test_mode())
+ return;
+
RenderThread::Get()->GetServiceRegistry()->ConnectToRemoteService(
name, std::move(handle));
}
« no previous file with comments | « no previous file | content/shell/renderer/layout_test/blink_test_runner.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698