Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2744)

Unified Diff: content/shell/renderer/layout_test/blink_test_runner.cc

Issue 1844033004: Revert of Change the battery-status layout tests to use JS mocks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/shell/renderer/layout_test/blink_test_runner.cc
diff --git a/content/shell/renderer/layout_test/blink_test_runner.cc b/content/shell/renderer/layout_test/blink_test_runner.cc
index 987d2672ec7048f9bf321610527f2c98815cbaf7..67cb1028323b679493d08287bd6b4c67bbbaf925 100644
--- a/content/shell/renderer/layout_test/blink_test_runner.cc
+++ b/content/shell/renderer/layout_test/blink_test_runner.cc
@@ -34,12 +34,10 @@
#include "components/test_runner/web_test_proxy.h"
#include "components/test_runner/web_test_runner.h"
#include "content/public/common/content_switches.h"
-#include "content/public/common/service_registry.h"
#include "content/public/common/url_constants.h"
#include "content/public/common/web_preferences.h"
#include "content/public/renderer/media_stream_utils.h"
#include "content/public/renderer/render_frame.h"
-#include "content/public/renderer/render_thread.h"
#include "content/public/renderer/render_view.h"
#include "content/public/renderer/render_view_visitor.h"
#include "content/public/renderer/renderer_gamepad_provider.h"
@@ -597,16 +595,6 @@
}
void BlinkTestRunner::TestFinished() {
- // In layout tests, mock Mojo service factories implemented in JS may be
- // installed on the per-frame and the per-process service registries. With
- // the test finished, clear any overrides so they don't interfere with any
- // later tests and so they aren't detected as leaks.
- RenderThread::Get()->GetServiceRegistry()->ClearServiceOverridesForTesting();
- render_view()
- ->GetMainRenderFrame()
- ->GetServiceRegistry()
- ->ClearServiceOverridesForTesting();
-
if (!is_main_window_ || !render_view()->GetMainRenderFrame()) {
Send(new ShellViewHostMsg_TestFinishedInSecondaryRenderer(routing_id()));
return;
« no previous file with comments | « content/renderer/renderer_blink_platform_impl.cc ('k') | third_party/WebKit/LayoutTests/battery-status/api-defined.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698