Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 1842953002: [Extensions] Convert APIs to use movable types [13] (Closed)

Created:
4 years, 8 months ago by Devlin
Modified:
4 years, 8 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions] Convert APIs to use movable types [13] Generated extensions code used to rely on linked_ptrs for non-copyable types in containers. Now, we can make these types movable. Update the following APIs to use movable types in this CL: - serial.idl - socket.idl - sockets_tcp.idl - sockets_tcp_server.idl - sockets_udp.idl - system_cpu.idl - system_display.idl - system_memory.idl - system_network.idl - system_storage.idl BUG=595949 Committed: https://crrev.com/d91f8ca4e5fdec5d220c6176d3f28c50834cb3f7 Cr-Commit-Position: refs/heads/master@{#384416}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+298 lines, -335 lines) Patch
M chrome/browser/extensions/display_info_provider_aura.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/display_info_provider_chromeos.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/display_info_provider_chromeos_unittest.cc View 18 chunks +144 lines, -154 lines 0 comments Download
M chrome/browser/extensions/display_info_provider_mac.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/extensions/display_info_provider_win.cc View 3 chunks +10 lines, -10 lines 0 comments Download
M extensions/browser/api/serial/serial_api.h View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/browser/api/serial/serial_api.cc View 4 chunks +13 lines, -14 lines 0 comments Download
M extensions/browser/api/socket/socket_api.cc View 1 chunk +7 lines, -10 lines 0 comments Download
M extensions/browser/api/sockets_tcp/sockets_tcp_api.cc View 4 chunks +16 lines, -20 lines 0 comments Download
M extensions/browser/api/sockets_tcp_server/sockets_tcp_server_api.cc View 3 chunks +12 lines, -16 lines 0 comments Download
M extensions/browser/api/sockets_udp/sockets_udp_api.cc View 3 chunks +14 lines, -19 lines 0 comments Download
M extensions/browser/api/system_cpu/cpu_info_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/system_cpu/cpu_info_provider.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M extensions/browser/api/system_cpu/cpu_info_provider_linux.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M extensions/browser/api/system_cpu/cpu_info_provider_mac.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M extensions/browser/api/system_cpu/cpu_info_provider_win.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M extensions/browser/api/system_cpu/system_cpu_apitest.cc View 1 chunk +5 lines, -6 lines 0 comments Download
M extensions/browser/api/system_display/display_info_provider.h View 3 chunks +2 lines, -4 lines 0 comments Download
M extensions/browser/api/system_display/display_info_provider.cc View 2 chunks +21 lines, -22 lines 0 comments Download
M extensions/browser/api/system_display/system_display_api.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M extensions/browser/api/system_network/system_network_api.cc View 1 chunk +7 lines, -10 lines 0 comments Download
M extensions/browser/api/system_storage/storage_info_provider.h View 2 chunks +2 lines, -3 lines 0 comments Download
M extensions/browser/api/system_storage/storage_info_provider.cc View 2 chunks +3 lines, -7 lines 0 comments Download
M extensions/common/api/serial.idl View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/api/socket.idl View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/api/sockets_tcp.idl View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/api/sockets_tcp_server.idl View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/api/sockets_udp.idl View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/api/system_cpu.idl View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/api/system_display.idl View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/api/system_memory.idl View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/api/system_network.idl View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/api/system_storage.idl View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/api/web_request.json View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/common/api/web_request_internal.json View 1 chunk +2 lines, -1 line 0 comments Download
M extensions/shell/browser/shell_display_info_provider.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Devlin
Nearly done! (Don't worry about the size - 150 lines are from one file changing ...
4 years, 8 months ago (2016-03-30 21:03:55 UTC) #4
asargent_no_longer_on_chrome
lgtm
4 years, 8 months ago (2016-03-31 20:17:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1842953002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1842953002/20001
4 years, 8 months ago (2016-03-31 22:05:38 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 8 months ago (2016-03-31 22:19:39 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-03-31 22:22:49 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d91f8ca4e5fdec5d220c6176d3f28c50834cb3f7
Cr-Commit-Position: refs/heads/master@{#384416}

Powered by Google App Engine
This is Rietveld 408576698