Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2379)

Unified Diff: extensions/browser/api/sockets_tcp_server/sockets_tcp_server_api.cc

Issue 1842953002: [Extensions] Convert APIs to use movable types [13] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/sockets_tcp_server/sockets_tcp_server_api.cc
diff --git a/extensions/browser/api/sockets_tcp_server/sockets_tcp_server_api.cc b/extensions/browser/api/sockets_tcp_server/sockets_tcp_server_api.cc
index 981f7f56f97ddc6eb4b24e1fae2e0c75f8b13b59..bc39c83fe889a4ebaf3fbdfc4d795a7e810a0b59 100644
--- a/extensions/browser/api/sockets_tcp_server/sockets_tcp_server_api.cc
+++ b/extensions/browser/api/sockets_tcp_server/sockets_tcp_server_api.cc
@@ -23,24 +23,23 @@ const char kSocketNotFoundError[] = "Socket not found";
const char kPermissionError[] = "Does not have permission";
const int kDefaultListenBacklog = SOMAXCONN;
-linked_ptr<SocketInfo> CreateSocketInfo(int socket_id,
- ResumableTCPServerSocket* socket) {
- linked_ptr<SocketInfo> socket_info(new SocketInfo());
+SocketInfo CreateSocketInfo(int socket_id, ResumableTCPServerSocket* socket) {
+ SocketInfo socket_info;
// This represents what we know about the socket, and does not call through
// to the system.
- socket_info->socket_id = socket_id;
+ socket_info.socket_id = socket_id;
if (!socket->name().empty()) {
- socket_info->name.reset(new std::string(socket->name()));
+ socket_info.name.reset(new std::string(socket->name()));
}
- socket_info->persistent = socket->persistent();
- socket_info->paused = socket->paused();
+ socket_info.persistent = socket->persistent();
+ socket_info.paused = socket->paused();
// Grab the local address as known by the OS.
net::IPEndPoint localAddress;
if (socket->GetLocalAddress(&localAddress)) {
- socket_info->local_address.reset(
+ socket_info.local_address.reset(
new std::string(localAddress.ToStringWithoutPort()));
- socket_info->local_port.reset(new int(localAddress.port()));
+ socket_info.local_port.reset(new int(localAddress.port()));
}
return socket_info;
@@ -269,9 +268,9 @@ void SocketsTcpServerGetInfoFunction::Work() {
return;
}
- linked_ptr<sockets_tcp_server::SocketInfo> socket_info =
+ sockets_tcp_server::SocketInfo socket_info =
CreateSocketInfo(params_->socket_id, socket);
- results_ = sockets_tcp_server::GetInfo::Results::Create(*socket_info);
+ results_ = sockets_tcp_server::GetInfo::Results::Create(socket_info);
}
SocketsTcpServerGetSocketsFunction::SocketsTcpServerGetSocketsFunction() {}
@@ -281,13 +280,10 @@ SocketsTcpServerGetSocketsFunction::~SocketsTcpServerGetSocketsFunction() {}
bool SocketsTcpServerGetSocketsFunction::Prepare() { return true; }
void SocketsTcpServerGetSocketsFunction::Work() {
- std::vector<linked_ptr<sockets_tcp_server::SocketInfo> > socket_infos;
+ std::vector<sockets_tcp_server::SocketInfo> socket_infos;
base::hash_set<int>* resource_ids = GetSocketIds();
if (resource_ids != NULL) {
- for (base::hash_set<int>::iterator it = resource_ids->begin();
- it != resource_ids->end();
- ++it) {
- int socket_id = *it;
+ for (int socket_id : *resource_ids) {
ResumableTCPServerSocket* socket = GetTcpSocket(socket_id);
if (socket) {
socket_infos.push_back(CreateSocketInfo(socket_id, socket));
« no previous file with comments | « extensions/browser/api/sockets_tcp/sockets_tcp_api.cc ('k') | extensions/browser/api/sockets_udp/sockets_udp_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698