Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2342)

Unified Diff: extensions/browser/api/system_network/system_network_api.cc

Issue 1842953002: [Extensions] Convert APIs to use movable types [13] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/system_network/system_network_api.cc
diff --git a/extensions/browser/api/system_network/system_network_api.cc b/extensions/browser/api/system_network/system_network_api.cc
index 0cf8d0a0ece0a2761c242bff196ad4dd1df3b261..0b196bd617ebc33b2a069580479465918a18740a 100644
--- a/extensions/browser/api/system_network/system_network_api.cc
+++ b/extensions/browser/api/system_network/system_network_api.cc
@@ -62,17 +62,14 @@ void SystemNetworkGetNetworkInterfacesFunction::SendResponseOnUIThread(
const net::NetworkInterfaceList& interface_list) {
DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
- std::vector<linked_ptr<api::system_network::NetworkInterface>> create_arg;
+ std::vector<api::system_network::NetworkInterface> create_arg;
create_arg.reserve(interface_list.size());
- for (net::NetworkInterfaceList::const_iterator i = interface_list.begin();
- i != interface_list.end();
- ++i) {
- linked_ptr<api::system_network::NetworkInterface> info =
- make_linked_ptr(new api::system_network::NetworkInterface);
- info->name = i->name;
- info->address = i->address.ToString();
- info->prefix_length = i->prefix_length;
- create_arg.push_back(info);
+ for (const net::NetworkInterface interface : interface_list) {
+ api::system_network::NetworkInterface info;
+ info.name = interface.name;
+ info.address = interface.address.ToString();
+ info.prefix_length = interface.prefix_length;
+ create_arg.push_back(std::move(info));
}
results_ =

Powered by Google App Engine
This is Rietveld 408576698