Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Side by Side Diff: extensions/browser/api/serial/serial_api.cc

Issue 1842953002: [Extensions] Convert APIs to use movable types [13] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « extensions/browser/api/serial/serial_api.h ('k') | extensions/browser/api/socket/socket_api.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "extensions/browser/api/serial/serial_api.h" 5 #include "extensions/browser/api/serial/serial_api.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/values.h" 10 #include "base/values.h"
(...skipping 72 matching lines...) Expand 10 before | Expand all | Expand 10 after
83 return true; 83 return true;
84 } 84 }
85 85
86 void SerialGetDevicesFunction::Work() { 86 void SerialGetDevicesFunction::Work() {
87 DCHECK_CURRENTLY_ON(BrowserThread::FILE); 87 DCHECK_CURRENTLY_ON(BrowserThread::FILE);
88 88
89 scoped_ptr<device::SerialDeviceEnumerator> enumerator = 89 scoped_ptr<device::SerialDeviceEnumerator> enumerator =
90 device::SerialDeviceEnumerator::Create(); 90 device::SerialDeviceEnumerator::Create();
91 mojo::Array<device::serial::DeviceInfoPtr> devices = enumerator->GetDevices(); 91 mojo::Array<device::serial::DeviceInfoPtr> devices = enumerator->GetDevices();
92 results_ = serial::GetDevices::Results::Create( 92 results_ = serial::GetDevices::Results::Create(
93 devices.To<std::vector<linked_ptr<serial::DeviceInfo> > >()); 93 devices.To<std::vector<serial::DeviceInfo>>());
94 } 94 }
95 95
96 SerialConnectFunction::SerialConnectFunction() { 96 SerialConnectFunction::SerialConnectFunction() {
97 } 97 }
98 98
99 SerialConnectFunction::~SerialConnectFunction() { 99 SerialConnectFunction::~SerialConnectFunction() {
100 } 100 }
101 101
102 bool SerialConnectFunction::Prepare() { 102 bool SerialConnectFunction::Prepare() {
103 params_ = serial::Connect::Params::Create(*args_); 103 params_ = serial::Connect::Params::Create(*args_);
(...skipping 239 matching lines...) Expand 10 before | Expand all | Expand 10 after
343 } 343 }
344 344
345 SerialGetConnectionsFunction::~SerialGetConnectionsFunction() { 345 SerialGetConnectionsFunction::~SerialGetConnectionsFunction() {
346 } 346 }
347 347
348 bool SerialGetConnectionsFunction::Prepare() { 348 bool SerialGetConnectionsFunction::Prepare() {
349 return true; 349 return true;
350 } 350 }
351 351
352 void SerialGetConnectionsFunction::Work() { 352 void SerialGetConnectionsFunction::Work() {
353 std::vector<linked_ptr<serial::ConnectionInfo> > infos; 353 std::vector<serial::ConnectionInfo> infos;
354 const base::hash_set<int>* connection_ids = 354 const base::hash_set<int>* connection_ids =
355 manager_->GetResourceIds(extension_->id()); 355 manager_->GetResourceIds(extension_->id());
356 if (connection_ids) { 356 if (connection_ids) {
357 for (base::hash_set<int>::const_iterator it = connection_ids->begin(); 357 for (base::hash_set<int>::const_iterator it = connection_ids->begin();
358 it != connection_ids->end(); 358 it != connection_ids->end();
359 ++it) { 359 ++it) {
360 int connection_id = *it; 360 int connection_id = *it;
361 SerialConnection* connection = GetSerialConnection(connection_id); 361 SerialConnection* connection = GetSerialConnection(connection_id);
362 if (connection) { 362 if (connection) {
363 linked_ptr<serial::ConnectionInfo> info(new serial::ConnectionInfo()); 363 serial::ConnectionInfo info;
364 info->connection_id = connection_id; 364 info.connection_id = connection_id;
365 connection->GetInfo(info.get()); 365 connection->GetInfo(&info);
366 infos.push_back(info); 366 infos.push_back(std::move(info));
367 } 367 }
368 } 368 }
369 } 369 }
370 results_ = serial::GetConnections::Results::Create(infos); 370 results_ = serial::GetConnections::Results::Create(infos);
371 } 371 }
372 372
373 SerialGetControlSignalsFunction::SerialGetControlSignalsFunction() { 373 SerialGetControlSignalsFunction::SerialGetControlSignalsFunction() {
374 } 374 }
375 375
376 SerialGetControlSignalsFunction::~SerialGetControlSignalsFunction() { 376 SerialGetControlSignalsFunction::~SerialGetControlSignalsFunction() {
(...skipping 93 matching lines...) Expand 10 before | Expand all | Expand 10 after
470 results_ = serial::ClearBreak::Results::Create(success); 470 results_ = serial::ClearBreak::Results::Create(success);
471 } 471 }
472 472
473 } // namespace api 473 } // namespace api
474 474
475 } // namespace extensions 475 } // namespace extensions
476 476
477 namespace mojo { 477 namespace mojo {
478 478
479 // static 479 // static
480 linked_ptr<extensions::api::serial::DeviceInfo> TypeConverter< 480 extensions::api::serial::DeviceInfo TypeConverter<
481 linked_ptr<extensions::api::serial::DeviceInfo>, 481 extensions::api::serial::DeviceInfo,
482 device::serial::DeviceInfoPtr>::Convert(const device::serial::DeviceInfoPtr& 482 device::serial::DeviceInfoPtr>::Convert(const device::serial::DeviceInfoPtr&
483 device) { 483 device) {
484 linked_ptr<extensions::api::serial::DeviceInfo> info( 484 extensions::api::serial::DeviceInfo info;
485 new extensions::api::serial::DeviceInfo); 485 info.path = device->path;
486 info->path = device->path;
487 if (device->has_vendor_id) 486 if (device->has_vendor_id)
488 info->vendor_id.reset(new int(static_cast<int>(device->vendor_id))); 487 info.vendor_id.reset(new int(static_cast<int>(device->vendor_id)));
489 if (device->has_product_id) 488 if (device->has_product_id)
490 info->product_id.reset(new int(static_cast<int>(device->product_id))); 489 info.product_id.reset(new int(static_cast<int>(device->product_id)));
491 if (device->display_name) 490 if (device->display_name)
492 info->display_name.reset(new std::string(device->display_name)); 491 info.display_name.reset(new std::string(device->display_name));
493 return info; 492 return info;
494 } 493 }
495 494
496 } // namespace mojo 495 } // namespace mojo
OLDNEW
« no previous file with comments | « extensions/browser/api/serial/serial_api.h ('k') | extensions/browser/api/socket/socket_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698