Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(505)

Issue 2056773002: Make ap effective. (Closed)

Created:
4 years, 6 months ago by Sorin Jianu
Modified:
4 years, 6 months ago
Reviewers:
waffles
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make ap effective. The value must be propagated to the CrxInstaller for the feature to work end to end. Changed the order of assignments to match the order of member declaration in CrxInstaller class. R=waffles BUG=599703 Committed: https://crrev.com/98fc1d664ac27ba8e840abc147049279668a751a Cr-Commit-Position: refs/heads/master@{#399042}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M components/component_updater/default_component_installer.cc View 1 2 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Sorin Jianu
4 years, 6 months ago (2016-06-09 19:23:14 UTC) #2
waffles
lgtm
4 years, 6 months ago (2016-06-09 19:28:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2056773002/40001
4 years, 6 months ago (2016-06-09 22:21:11 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-09 22:48:03 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-09 22:49:55 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/98fc1d664ac27ba8e840abc147049279668a751a
Cr-Commit-Position: refs/heads/master@{#399042}

Powered by Google App Engine
This is Rietveld 408576698