Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1880823002: Fix crash in update_client::BackgroundDownloader::EndDownload. (Closed)

Created:
4 years, 8 months ago by Sorin Jianu
Modified:
4 years, 8 months ago
Reviewers:
waffles
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix crash in update_client::BackgroundDownloader::EndDownload. This happens only in debug builds when the BITS service is disabled or other COM error occurs at the beginning of the BITS download. BUG=601451 Committed: https://crrev.com/9ce36b54bdc5e78b1464b8c1136c5b80826c4767 Cr-Commit-Position: refs/heads/master@{#386550}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M components/update_client/background_downloader_win.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M components/update_client/background_downloader_win.cc View 1 2 chunks +5 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (8 generated)
waffles
lgtm
4 years, 8 months ago (2016-04-12 00:11:01 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1880823002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1880823002/20001
4 years, 8 months ago (2016-04-12 00:11:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1880823002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1880823002/20001
4 years, 8 months ago (2016-04-12 00:19:16 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-12 01:58:30 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-12 02:00:02 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9ce36b54bdc5e78b1464b8c1136c5b80826c4767
Cr-Commit-Position: refs/heads/master@{#386550}

Powered by Google App Engine
This is Rietveld 408576698