Issue 1842563006: DO NOT SUBMIT. Experimental Mac GN Framework support.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1842563006: DO NOT SUBMIT. Experimental Mac GN Framework support. (Closed)

Created:
4 years, 8 months ago by Robert Sesek

Modified:
4 years, 8 months ago

Reviewers:
Nico

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

DO NOT SUBMIT. Experimental Mac GN Framework support. R=thakis@chromium.org

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Working framework #

Patch Set 4 : Versioned frameworks #

Patch Set 5 : ui_base_unittests passes! #

Patch Set 6 : Broken Content Shell Framework #

Patch Set 7 : Binary bundle data #

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+253 lines, -23 lines)			Patch
M	build/config/mac/rules.gni	View	1 2 3 4 5 6	1 chunk	+128 lines, -0 lines	0 comments	Download
M	build/toolchain/mac/BUILD.gn	View	1 2 3 4 5 6	1 chunk	+2 lines, -2 lines	0 comments	Download
M	content/shell/BUILD.gn	View	1 2 3 4 5	3 chunks	+5 lines, -7 lines	0 comments	Download
M	tools/gn/bundle_data.h	View	1 2 3 4 5 6	2 chunks	+7 lines, -0 lines	0 comments	Download
M	tools/gn/bundle_data.cc	View	1 2 3 4 5 6	2 chunks	+3 lines, -2 lines	0 comments	Download
M	tools/gn/bundle_data_target_generator.cc	View	1 2 3 4 5 6	1 chunk	+10 lines, -0 lines	0 comments	Download
M	tools/gn/bundle_file_rule.h	View	1 2 3 4 5 6	2 chunks	+5 lines, -1 line	0 comments	Download
M	tools/gn/bundle_file_rule.cc	View	1 2 3 4 5 6	1 chunk	+3 lines, -2 lines	0 comments	Download
M	tools/gn/function_toolchain.cc	View	1 2 3 4 5 6	1 chunk	+4 lines, -2 lines	0 comments	Download
M	tools/gn/ninja_create_bundle_target_writer.cc	View	1 2 3 4 5 6	1 chunk	+3 lines, -0 lines	0 comments	Download
M	tools/gn/substitution_type.h	View	1 2 3 4 5 6	2 chunks	+2 lines, -0 lines	0 comments	Download
M	tools/gn/substitution_type.cc	View	1 2 3 4 5 6	3 chunks	+7 lines, -0 lines	0 comments	Download
M	tools/gn/target.cc	View	1 2 3 4 5	1 chunk	+7 lines, -4 lines	0 comments	Download
M	tools/gn/variables.h	View	1 2 3 4 5 6	1 chunk	+4 lines, -0 lines	0 comments	Download
M	tools/gn/variables.cc	View	1 2 3 4 5 6	2 chunks	+11 lines, -0 lines	0 comments	Download
M	ui/base/BUILD.gn	View	1 2 3 4 5	3 chunks	+13 lines, -2 lines	0 comments	Download
M	ui/resources/BUILD.gn	View	1 2 3 4	2 chunks	+39 lines, -1 line	0 comments	Download