Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Unified Diff: tools/gn/bundle_data_target_generator.cc

Issue 1842563006: DO NOT SUBMIT. Experimental Mac GN Framework support. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Binary bundle data Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/bundle_data.cc ('k') | tools/gn/bundle_file_rule.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/bundle_data_target_generator.cc
diff --git a/tools/gn/bundle_data_target_generator.cc b/tools/gn/bundle_data_target_generator.cc
index 81a9b959ebc3b8ae81bbf1c60d0004851e1b6420..96f490a350b4b8f524b7f17a961c38720e6557a3 100644
--- a/tools/gn/bundle_data_target_generator.cc
+++ b/tools/gn/bundle_data_target_generator.cc
@@ -27,6 +27,16 @@ void BundleDataTargetGenerator::DoRun() {
if (!FillOutputs())
return;
+ const Value* value = scope_->GetValue(variables::kBinaryCompress, true);
+ if (value) {
+ if (value->type() != Value::BOOLEAN) {
+ *err_ = Err(function_call_,
+ "The binary_compress variable must be boolean");
+ return;
+ }
+ target_->bundle_data().set_binary_compress(value->boolean_value());
+ }
+
if (target_->sources().empty()) {
*err_ = Err(function_call_, "Empty sources for bundle_data target."
"You have to specify at least one file in the \"sources\".");
« no previous file with comments | « tools/gn/bundle_data.cc ('k') | tools/gn/bundle_file_rule.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698