Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2145)

Unified Diff: content/shell/BUILD.gn

Issue 1842563006: DO NOT SUBMIT. Experimental Mac GN Framework support. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Binary bundle data Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/toolchain/mac/BUILD.gn ('k') | tools/gn/bundle_data.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/shell/BUILD.gn
diff --git a/content/shell/BUILD.gn b/content/shell/BUILD.gn
index 4fd4c916c8ace4664680bec56620b89096fcff6c..4ea30cd6c962664e58f2f47fabf201552fde418b 100644
--- a/content/shell/BUILD.gn
+++ b/content/shell/BUILD.gn
@@ -12,6 +12,8 @@ import("//tools/grit/repack.gni")
import("//tools/grit/grit_rule.gni")
if (is_android) {
import("//build/config/android/config.gni")
+} else if (is_mac) {
+ import("//build/config/mac/rules.gni")
}
declare_args() {
@@ -511,15 +513,9 @@ if (is_win) {
}
if (is_mac) {
- # TODO(GYP) this should be a bundle. Lots of other stuff in this target.
- # GYP version: content/content_shell.gypi:content_shell_framework
- shared_library("framework") {
+ mac_framework("$content_shell_product_name Framework") {
testonly = true
- # TODO(GYP) bug 546894: Fix GN and toolchains to handle spaces here.
- #output_name = "$content_shell_product_name Framework"
- output_name = "content_shell_framework" # Temporary one with no spaces.
-
sources = [
"app/shell_content_main.cc",
"app/shell_content_main.h",
@@ -528,5 +524,7 @@ if (is_mac) {
deps = [
":content_shell_lib",
]
+
+ info_plist = "app/framework-Info.plist"
}
}
« no previous file with comments | « build/toolchain/mac/BUILD.gn ('k') | tools/gn/bundle_data.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698