Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Unified Diff: tools/gn/substitution_type.cc

Issue 1842563006: DO NOT SUBMIT. Experimental Mac GN Framework support. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Binary bundle data Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/substitution_type.h ('k') | tools/gn/target.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/substitution_type.cc
diff --git a/tools/gn/substitution_type.cc b/tools/gn/substitution_type.cc
index e1ea14de94799c84743d16d1cec660b442e3c457..308880161b7090c2ee202c684b1b6a2c4bfb29a5 100644
--- a/tools/gn/substitution_type.cc
+++ b/tools/gn/substitution_type.cc
@@ -50,6 +50,7 @@ const char* kSubstitutionNames[SUBSTITUTION_NUM_TYPES] = {
"{{bundle_resources_dir}}", // SUBSTITUTION_BUNDLE_RESOURCES_DIR
"{{bundle_executable_dir}}", // SUBSTITUTION_BUNDLE_EXECUTABLE_DIR
"{{bundle_plugins_dir}}", // SUBSTITUTION_BUNDLE_PLUGINS_DIR
+ "{{binary_compress}}", // SUBSTITUTION_BUNDLE_BINARY_COMPRESS
"{{response_file_name}}", // SUBSTITUTION_RSP_FILE_NAME
};
@@ -98,6 +99,7 @@ const char* kSubstitutionNinjaNames[SUBSTITUTION_NUM_TYPES] = {
"bundle_resources_dir", // SUBSTITUTION_BUNDLE_RESOURCES_DIR
"bundle_executable_dir", // SUBSTITUTION_BUNDLE_EXECUTABLE_DIR
"bundle_plugins_dir", // SUBSTITUTION_BUNDLE_PLUGINS_DIR
+ "binary_compress", // SUBSTITUTION_BUNDLE_BINARY_COMPRESS
"rspfile", // SUBSTITUTION_RSP_FILE_NAME
};
@@ -208,6 +210,11 @@ bool IsValidCopySubstitution(SubstitutionType type) {
type == SUBSTITUTION_SOURCE;
}
+bool IsValidCopyBundleDataSubstitution(SubstitutionType type) {
+ return IsValidCopySubstitution(type) ||
+ type == SUBSTITUTION_BUNDLE_BINARY_COMPRESS;
+}
+
bool IsValidCompileXCassetsSubstitution(SubstitutionType type) {
return IsValidToolSubstitution(type) ||
type == SUBSTITUTION_LINKER_INPUTS;
« no previous file with comments | « tools/gn/substitution_type.h ('k') | tools/gn/target.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698