Start making server strong mode clean

Start making server strong mode clean

R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/0d743fbacf7bf9d1c93e50fb61eb6cf1e8be5da5

[Brian Wilkerson, 2016-03-31 00:34:32]

brianwilkerson@google.com changed reviewers:
+ scheglov@google.com

[scheglov, 2016-03-31 00:53:18]

lgtm

https://codereview.chromium.org/1842063003/diff/20001/pkg/analysis_server/lib...
File pkg/analysis_server/lib/src/context_manager.dart (right):

https://codereview.chromium.org/1842063003/diff/20001/pkg/analysis_server/lib...
pkg/analysis_server/lib/src/context_manager.dart:631:
setIgnorePatternsForContext(info, exclude as List<String>);
We can propagate the type of "exclude", but it is not enough for strong mode?
That's sad.

https://codereview.chromium.org/1842063003/diff/20001/pkg/analysis_server/lib...
File pkg/analysis_server/lib/src/plugin/server_plugin.dart (right):

https://codereview.chromium.org/1842063003/diff/20001/pkg/analysis_server/lib...
pkg/analysis_server/lib/src/plugin/server_plugin.dart:166: for (Object extension
in analyzedFilePatternsExtensionPoint.extensions) {
Should we make ExtensionPoint parameterized?

[Brian Wilkerson, 2016-03-31 15:27:09]

Description was changed from

==========
Start making server strong mode clean
==========

to

==========
Start making server strong mode clean

R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/0d743fbacf7bf9d1c93e50fb61eb6cf1e8be5da5
==========

[Brian Wilkerson, 2016-03-31 15:27:10]

Committed patchset #2 (id:20001) manually as
0d743fbacf7bf9d1c93e50fb61eb6cf1e8be5da5 (presubmit successful).

[Brian Wilkerson, 2016-03-31 15:27:12]

https://codereview.chromium.org/1842063003/diff/20001/pkg/analysis_server/lib...
File pkg/analysis_server/lib/src/context_manager.dart (right):

https://codereview.chromium.org/1842063003/diff/20001/pkg/analysis_server/lib...
pkg/analysis_server/lib/src/context_manager.dart:631:
setIgnorePatternsForContext(info, exclude as List<String>);
You're right, that does seem like it ought not to be necessary. I'll back it out
until we get further resolution.

https://codereview.chromium.org/1842063003/diff/20001/pkg/analysis_server/lib...
File pkg/analysis_server/lib/src/plugin/server_plugin.dart (right):

https://codereview.chromium.org/1842063003/diff/20001/pkg/analysis_server/lib...
pkg/analysis_server/lib/src/plugin/server_plugin.dart:166: for (Object extension
in analyzedFilePatternsExtensionPoint.extensions) {
> Should we make ExtensionPoint parameterized?

I thought about that, and I like the idea, but I didn't have the time to see
whether it could actually be done. I think it would work if we had generic
methods. I'll back out these changes until I've had a chance to investigate
further.

[Leaf, 2016-03-31 17:59:14]

leafp@google.com changed reviewers:
+ leafp@google.com

[Leaf, 2016-03-31 17:59:14]

https://codereview.chromium.org/1842063003/diff/20001/pkg/analysis_server/lib...
File pkg/analysis_server/lib/src/context_manager.dart (right):

https://codereview.chromium.org/1842063003/diff/20001/pkg/analysis_server/lib...
pkg/analysis_server/lib/src/context_manager.dart:631:
setIgnorePatternsForContext(info, exclude as List<String>);
On 2016/03/31 15:27:12, Brian Wilkerson wrote:
> You're right, that does seem like it ought not to be necessary. I'll back it
out
> until we get further resolution.

Intellij go to declaration can't seem to find the def of YamlList for me, so I'm
not sure I have the right class, but this YamlList:

https://www.dartdocs.org/documentation/yaml/2.1.8/yaml/YamlList-class.html

is a subtype of List<dynamic>.  That means that YamlList and List<String> are
not subtype related in strong mode (neither is a subtype of the other).  If I
recall correctly how the analyzer's promotion code works, this means no
promotion will happen.  Does that seem right?  Also, I believe that means the
cast will fail in strong mode.

[Brian Wilkerson, 2016-03-31 18:17:06]

https://codereview.chromium.org/1842063003/diff/20001/pkg/analysis_server/lib...
File pkg/analysis_server/lib/src/context_manager.dart (right):

https://codereview.chromium.org/1842063003/diff/20001/pkg/analysis_server/lib...
pkg/analysis_server/lib/src/context_manager.dart:631:
setIgnorePatternsForContext(info, exclude as List<String>);
Then the right solution is probably to change setIgnorePatternsForContext to
take a List<dynamic> and test the element types in that method.