Start making server strong mode clean

pkg/analysis_server/lib/src/status/get_handler.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library analysis_server.src.status.get_handler;
 
 import 'dart:collection';
 import 'dart:convert';
 import 'dart:io';
 import 'dart:math';
@@ skipping 868 matching lines @@
     String sourceUri = request.uri.queryParameters[SOURCE_QUERY_PARAM];
     if (sourceUri == null) {
       return _returnFailure(
           request, 'Query parameter $SOURCE_QUERY_PARAM required');
     }
 
     List<Folder> allContexts = <Folder>[];
     Map<Folder, List<CacheEntry>> entryMap =
         new HashMap<Folder, List<CacheEntry>>();
     StringBuffer invalidKeysBuffer = new StringBuffer();
-    analysisServer.folderMap
-        .forEach((Folder folder, InternalAnalysisContext context) {
+    analysisServer.folderMap.forEach((Folder folder, AnalysisContext context) {
       Source source = context.sourceFactory.forUri(sourceUri);
       if (source != null) {
         MapIterator<AnalysisTarget, CacheEntry> iterator =
-            context.analysisCache.iterator();
+            (context as InternalAnalysisContext).analysisCache.iterator();
         while (iterator.moveNext()) {
           if (source == iterator.key.source) {
             if (!allContexts.contains(folder)) {
               allContexts.add(folder);
             }
             List<CacheEntry> entries = entryMap[folder];
             if (entries == null) {
               entries = <CacheEntry>[];
               entryMap[folder] = entries;
             }
@@ skipping 311 matching lines @@
     String contextFilter = request.uri.queryParameters[CONTEXT_QUERY_PARAM];
     if (contextFilter == null) {
       return _returnFailure(
           request, 'Query parameter $CONTEXT_QUERY_PARAM required');
     }
     Folder folder = _findFolder(analysisServer, contextFilter);
     if (folder == null) {
       return _returnFailure(request, 'Invalid context: $contextFilter');
     }
 
-    List<String> priorityNames;
+    List<String> priorityNames = <String>[];
     List<String> explicitNames = <String>[];
     List<String> implicitNames = <String>[];
     Map<String, String> links = new HashMap<String, String>();
     List<CaughtException> exceptions = <CaughtException>[];
     InternalAnalysisContext context = analysisServer.folderMap[folder];
-    priorityNames = context.prioritySources
-        .map((Source source) => source.fullName)
-        .toList();
+    context.prioritySources.forEach((Source source) {
+      priorityNames.add(source.fullName);
+    });
     MapIterator<AnalysisTarget, CacheEntry> iterator =
         context.analysisCache.iterator(context: context);
     while (iterator.moveNext()) {
       AnalysisTarget target = iterator.key;
       if (target is Source) {
         CacheEntry entry = iterator.value;
         String sourceName = target.fullName;
         if (!links.containsKey(sourceName)) {
           CaughtException exception = entry.exception;
           if (exception != null) {
@@ skipping 85 matching lines @@
           (StringBuffer buffer) {
             buffer.write('<p><b>Context Options</b></p>');
             writeOptions(buffer, context.analysisOptions);
           },
           (StringBuffer buffer) {
             buffer.write('<p><b>SDK Context Options</b></p>');
             writeOptions(buffer,
                 context?.sourceFactory?.dartSdk?.context?.analysisOptions);
           },
           (StringBuffer buffer) {
-            List<Linter> lints =
-                context.getConfigurationData(CONFIGURED_LINTS_KEY);
+            List<Linter> lints = context
+                .getConfigurationData(CONFIGURED_LINTS_KEY) as List<Linter>;
             buffer.write('<p><b>Lints</b></p>');
             if (lints.isEmpty) {
               buffer.write('<p>none</p>');
             } else {
               for (Linter lint in lints) {
                 buffer.write('<p>');
                 buffer.write(lint.runtimeType);
                 buffer.write('</p>');
               }
             }
 
             List<ErrorProcessor> errorProcessors =
-                context.getConfigurationData(CONFIGURED_ERROR_PROCESSORS);
+                context.getConfigurationData(CONFIGURED_ERROR_PROCESSORS)
+                as List<ErrorProcessor>;
             int processorCount = errorProcessors?.length ?? 0;
             buffer
                 .write('<p><b>Error Processor count</b>: $processorCount</p>');
           }
         ]);
 
         SourceFactory sourceFactory = context.sourceFactory;
         if (sourceFactory is SourceFactoryImpl) {
           buffer.write('<h3>Resolvers</h3>');
           for (UriResolver resolver in sourceFactory.resolvers) {
@@ skipping 513 matching lines @@
 
     buffer.write('<h3>Timing</h3>');
 
     buffer.write('<p>getDiagnostic (last call): ');
     buffer.write(elapsedMs);
     buffer.write(' (ms)</p>');
     buffer.write('<p>getDiagnostic (rolling average): ');
     buffer.write(_diagnosticCallAverage.value);
     buffer.write(' (ms)</p>&nbsp;');
 
-    var json = response.toJson()[Response.RESULT];
+    Map json = response.toJson()[Response.RESULT];
     List contexts = json['contexts'];
     contexts.sort((first, second) => first['name'].compareTo(second['name']));
 
     // Track visited libraries.
     Set<LibraryElement> libraries = new HashSet<LibraryElement>();
 
     // Count SDK elements separately.
     ElementCounter sdkCounter = new ElementCounter();
 
     for (var context in contexts) {
@@ skipping 326 matching lines @@
    * given [response] object.
    */
   bool _writeServerStatus(StringBuffer buffer) {
     AnalysisServer analysisServer = _server.analysisServer;
     Set<ServerService> services = analysisServer.serverServices;
 
     buffer.write('<h3>Server Domain</h3>');
     _writeTwoColumns(buffer, (StringBuffer buffer) {
       if (analysisServer == null) {
         buffer.write('Status: <span style="color:red">Not running</span>');
-        return false;
+        return;
       }
       buffer.write('<p>');
       buffer.write('Status: Running<br>');
       buffer.write('Instrumentation: ');
       if (AnalysisEngine.instance.instrumentationService.isActive) {
         buffer.write('<span style="color:red">Active</span>');
       } else {
         buffer.write('Inactive');
       }
       buffer.write('<br>');
       buffer.write('Version: ');
       buffer.write(AnalysisServer.VERSION);
       buffer.write('<br>');
       buffer.write('Process ID: ');
       buffer.write(pid);
       buffer.write('</p>');
 
       buffer.write('<p><b>Performance Data</b></p>');
       buffer.write('<p>');
       buffer.write(makeLink(
           COMMUNICATION_PERFORMANCE_PATH, {}, 'Communication performance'));
       buffer.write('</p>');
       buffer.write('<p>');
       buffer.write(makeLink(DIAGNOSTIC_PATH, {}, 'General diagnostics'));
       buffer.write('</p>');
     }, (StringBuffer buffer) {
       _writeSubscriptionList(buffer, ServerService.VALUES, services);
     });
-    return true;
+    return analysisServer != null;
   }
 
   /**
    * Write a representation of the given [stackTrace] to the given [buffer].
    */
   void _writeStackTrace(StringBuffer buffer, StackTrace stackTrace) {
     if (stackTrace != null) {
       String trace = stackTrace.toString().replaceAll('#', '<br>#');
       if (trace.startsWith('<br>#')) {
         trace = trace.substring(4);
@@ skipping 183 matching lines @@
    */
   static String makeLink(
       String path, Map<String, String> params, String innerHtml,
       [bool hasError = false]) {
     Uri uri = new Uri(path: path, queryParameters: params);
     String href = HTML_ESCAPE.convert(uri.toString());
     String classAttribute = hasError ? ' class="error"' : '';
     return '<a href="$href"$classAttribute>$innerHtml</a>';
   }
 }