Start making server strong mode clean

pkg/analysis_server/lib/src/plugin/server_plugin.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library analysis_server.src.plugin.server_plugin;
 
 import 'package:analysis_server/plugin/analysis/analysis_domain.dart';
 import 'package:analysis_server/plugin/analysis/analyzed_files.dart';
 import 'package:analysis_server/plugin/analysis/navigation/navigation.dart';
 import 'package:analysis_server/plugin/analysis/navigation/navigation_core.dart';
@@ skipping 145 matching lines @@
    * Initialize a newly created plugin.
    */
   ServerPlugin();
 
   /**
    * Return a list containing all of the file patterns that can cause files to
    * be analyzed.
    */
   List<String> get analyzedFilePatterns {
     List<String> patterns = <String>[];
-    for (List<String> extension
-        in analyzedFilePatternsExtensionPoint.extensions) {
-      patterns.addAll(extension);
+    for (Object extension in analyzedFilePatternsExtensionPoint.extensions) {

[scheglov, 2016/03/31 00:53:18]

Should we make ExtensionPoint parameterized?

[Brian Wilkerson, 2016/03/31 15:27:12]

I thought about that, and I like the idea, but I didn't have the time to see
whether it could actually be done. I think it would work if we had generic
methods. I'll back out these changes until I've had a chance to investigate
further.

+      patterns.addAll(extension as List<String>);
     }
     return patterns;
   }
 
   /**
    * Return a list containing all of the assist contributors that were
    * contributed.
    */
   List<AssistContributor> get assistContributors =>
       assistContributorExtensionPoint.extensions;
 
   /**
    * Return a list containing all of the completion contributors that were
    * contributed.
    */
   Iterable<CompletionContributor> get completionContributors =>
       completionContributorExtensionPoint.extensions
-          .map((CompletionContributorFactory factory) => factory());
+          .map((Object factory) => (factory as CompletionContributorFactory)());
 
   /**
    * Return a list containing all of the fix contributors that were contributed.
    */
   List<FixContributor> get fixContributors =>
       fixContributorExtensionPoint.extensions;
 
   /**
    * Return a list containing all of the navigation contributors that were
    * contributed.
@@ skipping 20 matching lines @@
 
   /**
    * Use the given [server] to create all of the domains ([RequestHandler]'s)
    * that have been registered and return the newly created domains.
    */
   List<RequestHandler> createDomains(AnalysisServer server) {
     if (domainExtensionPoint == null) {
       return <RequestHandler>[];
     }
     return domainExtensionPoint.extensions
-        .map((RequestHandlerFactory factory) => factory(server))
+        .map((Object factory) => (factory as RequestHandlerFactory)(server))
         .toList();
   }
 
   @override
   void registerExtensionPoints(RegisterExtensionPoint registerExtensionPoint) {
     setAnalysisDomainExtensionPoint = registerExtensionPoint(
         SET_ANALISYS_DOMAIN_EXTENSION_POINT,
         _validateSetAnalysisDomainFunction);
     analyzedFilePatternsExtensionPoint = registerExtensionPoint(
         ANALYZED_FILE_PATTERNS_EXTENSION_POINT,
@@ skipping 170 matching lines @@
    * valid analysis domain receiver.
    */
   void _validateSetAnalysisDomainFunction(Object extension) {
     if (extension is! SetAnalysisDomain) {
       String id = setAnalysisDomainExtensionPoint.uniqueIdentifier;
       throw new ExtensionError(
           'Extensions to $id must be a SetAnalysisDomain function');
     }
   }
 }