Start making server strong mode clean

pkg/analysis_server/lib/src/plugin/server_plugin.dart

Index: pkg/analysis_server/lib/src/plugin/server_plugin.dart
diff --git a/pkg/analysis_server/lib/src/plugin/server_plugin.dart b/pkg/analysis_server/lib/src/plugin/server_plugin.dart
index 91ecb32d2b5ce8ebaa2433d92b06ce3e495e5745..d962f461df053a4f874fbd2cfdcd5271c2eb59a3 100644
--- a/pkg/analysis_server/lib/src/plugin/server_plugin.dart
+++ b/pkg/analysis_server/lib/src/plugin/server_plugin.dart
@@ -163,9 +163,8 @@ class ServerPlugin implements Plugin {
    */
   List<String> get analyzedFilePatterns {
     List<String> patterns = <String>[];
-    for (List<String> extension
-        in analyzedFilePatternsExtensionPoint.extensions) {
-      patterns.addAll(extension);
+    for (Object extension in analyzedFilePatternsExtensionPoint.extensions) {

[scheglov, 2016/03/31 00:53:18]

Should we make ExtensionPoint parameterized?

[Brian Wilkerson, 2016/03/31 15:27:12]

I thought about that, and I like the idea, but I didn't have the time to see
whether it could actually be done. I think it would work if we had generic
methods. I'll back out these changes until I've had a chance to investigate
further.

+      patterns.addAll(extension as List<String>);
     }
     return patterns;
   }
@@ -183,7 +182,7 @@ class ServerPlugin implements Plugin {
    */
   Iterable<CompletionContributor> get completionContributors =>
       completionContributorExtensionPoint.extensions
-          .map((CompletionContributorFactory factory) => factory());
+          .map((Object factory) => (factory as CompletionContributorFactory)());
 
   /**
    * Return a list containing all of the fix contributors that were contributed.
@@ -224,7 +223,7 @@ class ServerPlugin implements Plugin {
       return <RequestHandler>[];
     }
     return domainExtensionPoint.extensions
-        .map((RequestHandlerFactory factory) => factory(server))
+        .map((Object factory) => (factory as RequestHandlerFactory)(server))
         .toList();
   }