Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(970)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1841083005: Options: disallow bad URLs from being entered as startup pages (Closed)

Created:
4 years, 8 months ago by Dan Beam
Modified:
4 years, 8 months ago
Reviewers:
dpapad
CC:
chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@startup-browser-proxy
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Options: disallow bad URLs from being entered as startup pages R=dpapad@chromium.org BUG=399866 Committed: https://crrev.com/6f371b91430f4b90c1b14be0f338330de45bec82 Cr-Commit-Position: refs/heads/master@{#384499}

Patch Set 1 : fixes #

Total comments: 6

Patch Set 2 : dpapad@ review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -10 lines) Patch
M chrome/browser/ui/webui/options/startup_pages_handler.cc View 1 4 chunks +11 lines, -10 lines 0 comments Download
M chrome/browser/ui/webui/settings_utils.h View 1 2 chunks +9 lines, -0 lines 0 comments Download
A chrome/browser/ui/webui/settings_utils.cc View 1 1 chunk +22 lines, -0 lines 0 comments Download
A chrome/browser/ui/webui/settings_utils_unittest.cc View 1 1 chunk +28 lines, -0 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Issue 1845473002 Patch 40001

Dependent Patchsets:

Issue 1849543006 Patch 180001

Messages

Total messages: 11 (4 generated)
Dan Beam
4 years, 8 months ago (2016-03-31 18:50:56 UTC) #3
dpapad
https://codereview.chromium.org/1841083005/diff/10006/chrome/browser/ui/webui/options/startup_pages_handler.cc File chrome/browser/ui/webui/options/startup_pages_handler.cc (right): https://codereview.chromium.org/1841083005/diff/10006/chrome/browser/ui/webui/options/startup_pages_handler.cc#newcode170 chrome/browser/ui/webui/options/startup_pages_handler.cc:170: GURL url; Nit: s/url/fixed_url, for consistency with EditStartupPage below. ...
4 years, 8 months ago (2016-03-31 20:34:09 UTC) #4
Dan Beam
https://codereview.chromium.org/1841083005/diff/10006/chrome/browser/ui/webui/options/startup_pages_handler.cc File chrome/browser/ui/webui/options/startup_pages_handler.cc (right): https://codereview.chromium.org/1841083005/diff/10006/chrome/browser/ui/webui/options/startup_pages_handler.cc#newcode170 chrome/browser/ui/webui/options/startup_pages_handler.cc:170: GURL url; On 2016/03/31 20:34:08, dpapad wrote: > Nit: ...
4 years, 8 months ago (2016-03-31 22:04:41 UTC) #5
dpapad
lgtm
4 years, 8 months ago (2016-03-31 22:33:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1841083005/50001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1841083005/50001
4 years, 8 months ago (2016-04-01 05:33:00 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:50001)
4 years, 8 months ago (2016-04-01 05:59:11 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-01 06:01:03 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/6f371b91430f4b90c1b14be0f338330de45bec82
Cr-Commit-Position: refs/heads/master@{#384499}

Powered by Google App Engine
This is Rietveld 408576698