Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Side by Side Diff: chrome/browser/ui/webui/settings_utils_unittest.cc

Issue 1841083005: Options: disallow bad URLs from being entered as startup pages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@startup-browser-proxy
Patch Set: dpapad@ review Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/ui/webui/settings_utils.cc ('k') | chrome/chrome_browser_ui.gypi » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "chrome/browser/ui/webui/settings_utils.h"
6
7 #include "testing/gtest/include/gtest/gtest.h"
8 #include "url/gurl.h"
9
10 namespace settings_utils {
11
12 TEST(SettingsUtilsTest, FixupAndValidateStartupPage) {
13 EXPECT_FALSE(FixupAndValidateStartupPage(std::string(), nullptr));
14 EXPECT_FALSE(FixupAndValidateStartupPage(" ", nullptr));
15 EXPECT_FALSE(FixupAndValidateStartupPage("^&*@)^)", nullptr));
16 EXPECT_FALSE(FixupAndValidateStartupPage("chrome://quit", nullptr));
17
18 EXPECT_TRUE(FixupAndValidateStartupPage("facebook.com", nullptr));
19 EXPECT_TRUE(FixupAndValidateStartupPage("http://reddit.com", nullptr));
20 EXPECT_TRUE(FixupAndValidateStartupPage("https://google.com", nullptr));
21 EXPECT_TRUE(FixupAndValidateStartupPage("chrome://apps", nullptr));
22
23 GURL fixed_url;
24 EXPECT_TRUE(FixupAndValidateStartupPage("about:settings", &fixed_url));
25 EXPECT_EQ("chrome://settings/", fixed_url.spec());
26 }
27
28 } // namespace settings_utils
OLDNEW
« no previous file with comments | « chrome/browser/ui/webui/settings_utils.cc ('k') | chrome/chrome_browser_ui.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698