MD Settings: convert startup pages to use BrowserProxy/WebUIListeners

MD Settings: convert startup pages to use BrowserProxy/WebUIListeners

R=dschuyler@chromium.org
BUG=531750
Committed: https://crrev.com/8132ddc4ef5a323c59f12e077b6759e1e28995e4
Cr-Commit-Position: refs/heads/master@{#384183}

[Dan Beam, 2016-03-30 02:27:28]

Patchset #1 (id:1) has been deleted

[Dan Beam, 2016-03-30 02:27:48]

actual validation and tests coming

[Dan Beam, 2016-03-30 02:30:23]

https://codereview.chromium.org/1845473002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/on_startup_page/startup_urls_page.html
(left):

https://codereview.chromium.org/1845473002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/on_startup_page/startup_urls_page.html:3:
<link rel="import" href="chrome://resources/js/util.js">
ooops

https://codereview.chromium.org/1845473002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/on_startup_page/startup_urls_page.js
(right):

https://codereview.chromium.org/1845473002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/on_startup_page/startup_urls_page.js:97:
return this.browserProxy_ && this.browserProxy_.canAddPage(this.newUrl_);
i don't currently know whether the "this.browserProxy_ &&" is correct, but it is
required

[dschuyler, 2016-03-30 23:14:41]

LGTM with suggestions.

https://codereview.chromium.org/1845473002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/on_startup_page/startup_urls_page.js
(right):

https://codereview.chromium.org/1845473002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/on_startup_page/startup_urls_page.js:63: /**
Should there be an @param for the url

https://codereview.chromium.org/1845473002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/on_startup_page/startup_urls_page.js:97:
return this.browserProxy_ && this.browserProxy_.canAddPage(this.newUrl_);
On 2016/03/30 02:30:23, Dan Beam wrote:
> i don't currently know whether the "this.browserProxy_ &&" is correct, but it
is
> required

I asked Demetrios about it.  He suggested changing the 
browserProxy initialization from |attached| to |ready|.

[Dan Beam, 2016-03-31 00:06:28]

https://codereview.chromium.org/1845473002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/on_startup_page/startup_urls_page.js
(right):

https://codereview.chromium.org/1845473002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/on_startup_page/startup_urls_page.js:63: /**
On 2016/03/30 23:14:40, dschuyler wrote:
> Should there be an @param for the url

Done.

https://codereview.chromium.org/1845473002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/on_startup_page/startup_urls_page.js:97:
return this.browserProxy_ && this.browserProxy_.canAddPage(this.newUrl_);
On 2016/03/30 23:14:40, dschuyler wrote:
> On 2016/03/30 02:30:23, Dan Beam wrote:
> > i don't currently know whether the "this.browserProxy_ &&" is correct, but
it
> is
> > required
> 
> I asked Demetrios about it.  He suggested changing the 
> browserProxy initialization from |attached| to |ready|.

Done. (had to initialize browserProxy_ in created)

[Dan Beam, 2016-03-31 00:07:05]

The CQ bit was checked by dbeam@chromium.org

[Dan Beam, 2016-03-31 00:07:05]

The patchset sent to the CQ was uploaded after l-g-t-m from
dschuyler@chromium.org
Link to the patchset: https://codereview.chromium.org/1845473002/#ps40001
(title: "dschuyler review")

[commit-bot: I haz the power, 2016-03-31 00:07:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1845473002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1845473002/40001

[commit-bot: I haz the power, 2016-03-31 01:18:38]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-03-31 01:19:38]

Description was changed from

==========
MD Settings: convert startup pages to use BrowserProxy/WebUIListeners

R=dschuyler@chromium.org
BUG=531750
==========

to

==========
MD Settings: convert startup pages to use BrowserProxy/WebUIListeners

R=dschuyler@chromium.org
BUG=531750

Committed: https://crrev.com/8132ddc4ef5a323c59f12e077b6759e1e28995e4
Cr-Commit-Position: refs/heads/master@{#384183}
==========

[commit-bot: I haz the power, 2016-03-31 01:19:39]

Patchset 2 (id:??) landed as
https://crrev.com/8132ddc4ef5a323c59f12e077b6759e1e28995e4
Cr-Commit-Position: refs/heads/master@{#384183}